Fix remaining missing debugger build flags for open source builds#54774
Closed
huntie wants to merge 1 commit into
Closed
Fix remaining missing debugger build flags for open source builds#54774huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
huntie
force-pushed
the
export-D88284345
branch
from
8d77e02 to
4562693
Compare
…act#54774) Summary: NOTE: This diff is a backport of react#54770, where on the `0.83-stable` release branch, Network support for React Native DevTools was in a broken state under the open source build systems. ### Cause Network debugging support depends a number of `REACT_NATIVE_DEBUGGER_ENABLED` preprocessor flags, which we use to compile away any overhead in production builds. As we unfortunately use a total of **4 native build systems** today (with Buck 2 internally and primarily), the registration of these flags was missing across a number of native ObjC/C++ packages, which are now fixed with this PR. - D87864636 aimed to address this as we weren't seeing the Network panel at all. However, it was insufficient, as it has only partially enabled network features between platforms. ### This diff Add missing preprocessor flags in: - Android: - `src/main/jni/react/devsupport/CMakeLists.txt` - `src/main/jni/CMakeLists.txt` - iOS (Pods): - `React-jsinspectorNetwork` - iOS (`Package.swift`): - `Libraries/Network` Changelog: [Internal] Reviewed By: vzaidman Differential Revision: D88284345
huntie
force-pushed
the
export-D88284345
branch
from
4562693 to
090d671
Compare
Collaborator
|
This pull request was successfully merged by @huntie in 0874746 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
NOTE: This diff is a backport of #54770, where on the
0.83-stablerelease branch, Network support for React Native DevTools was in a broken state under the open source build systems.Cause
Network debugging support depends a number of
REACT_NATIVE_DEBUGGER_ENABLEDpreprocessor flags, which we use to compile away any overhead in production builds.As we unfortunately use a total of 4 native build systems today (with Buck 2 internally and primarily), the registration of these flags was missing across a number of native ObjC/C++ packages, which are now fixed with this PR.
This diff
Add missing preprocessor flags in:
src/main/jni/react/devsupport/CMakeLists.txtsrc/main/jni/CMakeLists.txtReact-jsinspectorNetworkPackage.swift):Libraries/NetworkChangelog: [Internal]
Differential Revision: D88284345