Add Flow lib defs for newer Node.js fs APIs#54992
Closed
robhogan wants to merge 1 commit into
Closed
Conversation
Summary: Node.js's `fs` has been updated considerably since it was first covered with Flow, and so far we've only added new APIs piecemeal as we need them. This goes through the whole module top to bottom and attempts to update in line with the Node.js docs at v24. Changelog: [Internal] Reviewed By: vzaidman Differential Revision: D89605689
d9bd766 to
29445c5
Compare
meta-codesync Bot
pushed a commit
to react/metro
that referenced
this pull request
Dec 30, 2025
Summary: X-link: react/react-native#54992 Node.js's `fs` has been updated considerably since it was first covered with Flow, and so far we've only added new APIs piecemeal as we need them. This goes through the whole module top to bottom and attempts to update in line with the Node.js docs at v24. Changelog: [Internal] Reviewed By: vzaidman Differential Revision: D89605689 fbshipit-source-id: 1ad0ef2f7fedb6416471461b8be7bc418afcd28f
|
This pull request has been merged in c98494b. |
Collaborator
|
This pull request was successfully merged by @robhogan in c98494b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Node.js's
fshas been updated considerably since it was first covered with Flow, and so far we've only added new APIs piecemeal as we need them.This goes through the whole module top to bottom and attempts to update in line with the Node.js docs at v24.
Changelog: [Internal]
Differential Revision: D89605689