Skip to content

Add Flow lib defs for newer Node.js fs APIs#54992

Closed
robhogan wants to merge 1 commit into
mainfrom
export-D89605689
Closed

Add Flow lib defs for newer Node.js fs APIs#54992
robhogan wants to merge 1 commit into
mainfrom
export-D89605689

Conversation

@robhogan

Copy link
Copy Markdown
Contributor

Summary:
Node.js's fs has been updated considerably since it was first covered with Flow, and so far we've only added new APIs piecemeal as we need them.

This goes through the whole module top to bottom and attempts to update in line with the Node.js docs at v24.

Changelog: [Internal]

Differential Revision: D89605689

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 29, 2025
@meta-codesync

meta-codesync Bot commented Dec 29, 2025

Copy link
Copy Markdown

@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89605689.

Summary:
Node.js's `fs` has been updated considerably since it was first covered with Flow, and so far we've only added new APIs piecemeal as we need them.

This goes through the whole module top to bottom and attempts to update in line with the Node.js docs at v24.

Changelog: [Internal]

Reviewed By: vzaidman

Differential Revision: D89605689
meta-codesync Bot pushed a commit to react/metro that referenced this pull request Dec 30, 2025
Summary:
X-link: react/react-native#54992

Node.js's `fs` has been updated considerably since it was first covered with Flow, and so far we've only added new APIs piecemeal as we need them.

This goes through the whole module top to bottom and attempts to update in line with the Node.js docs at v24.

Changelog: [Internal]

Reviewed By: vzaidman

Differential Revision: D89605689

fbshipit-source-id: 1ad0ef2f7fedb6416471461b8be7bc418afcd28f
@meta-codesync meta-codesync Bot closed this in c98494b Dec 30, 2025
@meta-codesync

meta-codesync Bot commented Dec 30, 2025

Copy link
Copy Markdown

This pull request has been merged in c98494b.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 30, 2025
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @robhogan in c98494b

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants