Skip to content

Remove redundant operator!= definitions in react-native-github #55746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NickGerleman wants to merge 1 commit into from
Closed

Remove redundant operator!= definitions in react-native-github #55746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/react-native/Libraries/FBLazyVector/FBLazyVector/FBLazyIterator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,6 @@ LazyIterator<T, U> operator+(typename LazyIterator<T, U>::difference_type n, con
return i + n;
}

template <typename T, typename U>
bool operator!=(const LazyIterator<T, U> &a, const LazyIterator<T, U> &b)
{
return !(a == b);
}

template <typename T, typename U>
bool operator<=(const LazyIterator<T, U> &a, const LazyIterator<T, U> &b)
{
Expand Down
4 changes: 0 additions & 4 deletions packages/react-native/ReactCommon/jsinspector-modern/UniqueMonostate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ struct UniqueMonostate {
{
return true;
}
constexpr bool operator!=(const UniqueMonostate<key> & /*unused*/) const noexcept
{
return false;
}
constexpr bool operator<(const UniqueMonostate<key> & /*unused*/) const noexcept
{
return false;
Expand Down
6 changes: 0 additions & 6 deletions packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedStringBox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,4 @@ bool operator==(
}
}

bool operator!=(
const AttributedStringBox& lhs,
const AttributedStringBox& rhs) {
return !(lhs == rhs);
}

} // namespace facebook::react
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedStringBox.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ class AttributedStringBox final {
};

bool operator==(const AttributedStringBox &lhs, const AttributedStringBox &rhs);
bool operator!=(const AttributedStringBox &lhs, const AttributedStringBox &rhs);

} // namespace facebook::react

Expand Down
4 changes: 0 additions & 4 deletions packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ bool ParagraphAttributes::operator==(const ParagraphAttributes& rhs) const {
floatEquality(minimumFontScale, rhs.minimumFontScale);
}

bool ParagraphAttributes::operator!=(const ParagraphAttributes& rhs) const {
return !(*this == rhs);
}

#pragma mark - DebugStringConvertible

#if RN_DEBUG_STRING_CONVERTIBLE
Expand Down
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ class ParagraphAttributes : public DebugStringConvertible {
std::optional<TextAlignmentVertical> textAlignVertical{};

bool operator==(const ParagraphAttributes &rhs) const;
bool operator!=(const ParagraphAttributes &rhs) const;

#pragma mark - DebugStringConvertible

Expand Down
5 changes: 0 additions & 5 deletions packages/react-native/ReactCommon/react/renderer/components/scrollview/primitives.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ class ScrollViewMaintainVisibleContentPosition final {
return std::tie(this->minIndexForVisible, this->autoscrollToTopThreshold) ==
std::tie(rhs.minIndexForVisible, rhs.autoscrollToTopThreshold);
}

bool operator!=(const ScrollViewMaintainVisibleContentPosition &rhs) const
{
return !(*this == rhs);
}
};

} // namespace facebook::react
20 changes: 0 additions & 20 deletions packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityPrimitives.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@ inline static bool operator==(const AccessibilityAction &lhs, const Accessibilit
return lhs.name == rhs.name && lhs.label == rhs.label;
}

inline static bool operator!=(const AccessibilityAction &lhs, const AccessibilityAction &rhs)
{
return !(rhs == lhs);
}

struct AccessibilityState {
bool disabled{false};
bool selected{false};
Expand All @@ -76,11 +71,6 @@ constexpr bool operator==(const AccessibilityState &lhs, const AccessibilityStat
lhs.busy == rhs.busy && lhs.expanded == rhs.expanded;
}

constexpr bool operator!=(const AccessibilityState &lhs, const AccessibilityState &rhs)
{
return !(rhs == lhs);
}

struct AccessibilityLabelledBy {
std::vector<std::string> value{};
};
Expand All @@ -90,11 +80,6 @@ inline static bool operator==(const AccessibilityLabelledBy &lhs, const Accessib
return lhs.value == rhs.value;
}

inline static bool operator!=(const AccessibilityLabelledBy &lhs, const AccessibilityLabelledBy &rhs)
{
return !(lhs == rhs);
}

struct AccessibilityValue {
std::optional<int> min;
std::optional<int> max;
Expand All @@ -107,11 +92,6 @@ constexpr bool operator==(const AccessibilityValue &lhs, const AccessibilityValu
return lhs.min == rhs.min && lhs.max == rhs.max && lhs.now == rhs.now && lhs.text == rhs.text;
}

constexpr bool operator!=(const AccessibilityValue &lhs, const AccessibilityValue &rhs)
{
return !(rhs == lhs);
}

enum class ImportantForAccessibility : uint8_t {
Auto,
Yes,
Expand Down
20 changes: 0 additions & 20 deletions packages/react-native/ReactCommon/react/renderer/components/view/primitives.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,6 @@ inline static bool operator==(const ViewEvents &lhs, const ViewEvents &rhs)
return lhs.bits == rhs.bits;
}

inline static bool operator!=(const ViewEvents &lhs, const ViewEvents &rhs)
{
return lhs.bits != rhs.bits;
}

enum class BackfaceVisibility : uint8_t { Auto, Visible, Hidden };

enum class BorderCurve : uint8_t { Circular, Continuous };
Expand Down Expand Up @@ -212,11 +207,6 @@ struct CascadedRectangleEdges {
rhs.blockStart,
rhs.blockEnd);
}

bool operator!=(const CascadedRectangleEdges<T> &rhs) const
{
return !(*this == rhs);
}
};

template <typename T>
Expand Down Expand Up @@ -292,11 +282,6 @@ struct CascadedRectangleCorners {
rhs.startEnd,
rhs.startStart);
}

bool operator!=(const CascadedRectangleCorners<T> &rhs) const
{
return !(*this == rhs);
}
};

using BorderWidths = RectangleEdges<Float>;
Expand Down Expand Up @@ -324,11 +309,6 @@ struct BorderMetrics {
this->borderColors, this->borderWidths, this->borderRadii, this->borderCurves, this->borderStyles) ==
std::tie(rhs.borderColors, rhs.borderWidths, rhs.borderRadii, rhs.borderCurves, rhs.borderStyles);
}

bool operator!=(const BorderMetrics &rhs) const
{
return !(*this == rhs);
}
};

} // namespace facebook::react
5 changes: 0 additions & 5 deletions packages/react-native/ReactCommon/react/renderer/core/LayoutConstraints.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ inline bool operator==(const LayoutConstraints &lhs, const LayoutConstraints &rh
std::tie(rhs.minimumSize, rhs.maximumSize, rhs.layoutDirection);
}

inline bool operator!=(const LayoutConstraints &lhs, const LayoutConstraints &rhs)
{
return !(lhs == rhs);
}

} // namespace facebook::react

namespace std {
Expand Down
5 changes: 0 additions & 5 deletions packages/react-native/ReactCommon/react/renderer/core/LayoutContext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,4 @@ inline bool operator==(const LayoutContext &lhs, const LayoutContext &rhs)
rhs.viewportOffset);
}

inline bool operator!=(const LayoutContext &lhs, const LayoutContext &rhs)
{
return !(lhs == rhs);
}

} // namespace facebook::react
2 changes: 0 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/core/LayoutMetrics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ struct LayoutMetrics {
}

bool operator==(const LayoutMetrics &rhs) const = default;

bool operator!=(const LayoutMetrics &rhs) const = default;
};

/*
Expand Down
4 changes: 0 additions & 4 deletions packages/react-native/ReactCommon/react/renderer/core/RawPropsKey.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,4 @@ bool operator==(const RawPropsKey& lhs, const RawPropsKey& rhs) noexcept {
areFieldsEqual(lhs.suffix, rhs.suffix);
}

bool operator!=(const RawPropsKey& lhs, const RawPropsKey& rhs) noexcept {
return !(lhs == rhs);
}

} // namespace facebook::react
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/core/RawPropsKey.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,5 @@ class RawPropsKey final {
};

bool operator==(const RawPropsKey &lhs, const RawPropsKey &rhs) noexcept;
bool operator!=(const RawPropsKey &lhs, const RawPropsKey &rhs) noexcept;

} // namespace facebook::react
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/graphics/BackgroundPosition.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ struct BackgroundPosition {
BackgroundPosition() : top(ValueUnit{0.0f, UnitType::Point}), left(ValueUnit{0.0f, UnitType::Point}) {}

bool operator==(const BackgroundPosition &other) const = default;
bool operator!=(const BackgroundPosition &other) const = default;
};

} // namespace facebook::react
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/graphics/BackgroundRepeat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ struct BackgroundRepeat {
BackgroundRepeat() {}

bool operator==(const BackgroundRepeat &other) const = default;
bool operator!=(const BackgroundRepeat &other) const = default;
};

} // namespace facebook::react
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/graphics/BackgroundSize.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ struct BackgroundSizeLengthPercentage {
}

bool operator==(const BackgroundSizeLengthPercentage &other) const = default;
bool operator!=(const BackgroundSizeLengthPercentage &other) const = default;
};

enum class BackgroundSizeKeyword { Cover, Contain };
Expand Down
2 changes: 0 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/graphics/Point.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ struct Point {
}

inline bool operator==(const Point &rhs) const = default;

inline bool operator!=(const Point &rhs) const = default;
};

} // namespace facebook::react
Expand Down
19 changes: 0 additions & 19 deletions packages/react-native/ReactCommon/react/renderer/graphics/RadialGradient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ struct RadialGradientSize {
return x == other.x && y == other.y;
}

bool operator!=(const Dimensions &other) const
{
return !(*this == other);
}

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic toDynamic() const;
#endif
Expand All @@ -53,11 +48,6 @@ struct RadialGradientSize {
return value == other.value;
}

bool operator!=(const RadialGradientSize &other) const
{
return !(*this == other);
}

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic toDynamic() const;
#endif
Expand All @@ -74,11 +64,6 @@ struct RadialGradientPosition {
return top == other.top && left == other.left && right == other.right && bottom == other.bottom;
}

bool operator!=(const RadialGradientPosition &other) const
{
return !(*this == other);
}

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic toDynamic() const;
#endif
Expand All @@ -94,10 +79,6 @@ struct RadialGradient {
{
return shape == other.shape && size == other.size && position == other.position && colorStops == other.colorStops;
}
bool operator!=(const RadialGradient &other) const
{
return !(*this == other);
}

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic toDynamic() const;
Expand Down
5 changes: 0 additions & 5 deletions packages/react-native/ReactCommon/react/renderer/graphics/Rect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ struct Rect {
return std::tie(this->origin, this->size) == std::tie(rhs.origin, rhs.size);
}

bool operator!=(const Rect &rhs) const noexcept
{
return !(*this == rhs);
}

Float getMaxX() const noexcept
{
return size.width > 0 ? origin.x + size.width : origin.x;
Expand Down
5 changes: 0 additions & 5 deletions packages/react-native/ReactCommon/react/renderer/graphics/RectangleCorners.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ struct RectangleCorners {
std::tie(rhs.topLeft, rhs.topRight, rhs.bottomLeft, rhs.bottomRight);
}

bool operator!=(const RectangleCorners<T> &rhs) const noexcept
{
return !(*this == rhs);
}

bool isUniform() const noexcept
{
return topLeft == topRight && topLeft == bottomLeft && topLeft == bottomRight;
Expand Down
5 changes: 0 additions & 5 deletions packages/react-native/ReactCommon/react/renderer/graphics/RectangleEdges.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ struct RectangleEdges {
std::tie(rhs.left, rhs.top, rhs.right, rhs.bottom);
}

bool operator!=(const RectangleEdges<T> &rhs) const noexcept
{
return !(*this == rhs);
}

bool isUniform() const noexcept
{
return left == top && left == right && left == bottom;
Expand Down
5 changes: 0 additions & 5 deletions packages/react-native/ReactCommon/react/renderer/graphics/Size.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ inline bool operator==(const Size &rhs, const Size &lhs) noexcept
return std::tie(lhs.width, lhs.height) == std::tie(rhs.width, rhs.height);
}

inline bool operator!=(const Size &rhs, const Size &lhs) noexcept
{
return !(lhs == rhs);
}

} // namespace facebook::react

namespace std {
Expand Down
4 changes: 0 additions & 4 deletions packages/react-native/ReactCommon/react/renderer/graphics/Transform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,6 @@ bool Transform::operator==(const Transform& rhs) const noexcept {
return true;
}

bool Transform::operator!=(const Transform& rhs) const noexcept {
return !(*this == rhs);
}

Transform Transform::operator*(const Transform& rhs) const {
if (*this == Transform::Identity()) {
return rhs;
Expand Down
5 changes: 0 additions & 5 deletions packages/react-native/ReactCommon/react/renderer/graphics/Transform.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ struct TransformOrigin {
{
return xy[0] == other.xy[0] && xy[1] == other.xy[1] && z == other.z;
}
bool operator!=(const TransformOrigin &other) const
{
return !(*this == other);
}
bool isSet() const
{
return xy[0].value != 0.0f || xy[0].unit != UnitType::Undefined || xy[1].value != 0.0f ||
Expand Down Expand Up @@ -157,7 +153,6 @@ struct Transform {
* Equality operators.
*/
bool operator==(const Transform &rhs) const noexcept;
bool operator!=(const Transform &rhs) const noexcept;

/*
* Matrix subscript.
Expand Down
5 changes: 0 additions & 5 deletions packages/react-native/ReactCommon/react/renderer/graphics/ValueUnit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ struct ValueUnit {
return value == other.value && unit == other.unit;
}

constexpr bool operator!=(const ValueUnit &other) const
{
return !(*this == other);
}

constexpr float resolve(float referenceLength) const
{
switch (unit) {
Expand Down
5 changes: 0 additions & 5 deletions ...t/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageRequestParams.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,6 @@ class ImageRequestParams {
rhs.analyticTag,
rhs.size);
}

bool operator!=(const ImageRequestParams &rhs) const
{
return !(*this == rhs);
}
};

struct ImageRequestItem {
Expand Down
Loading
Loading