Exclude metainternal from C++ API snapshots (#56545)#56545
Closed
lavenzg wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Facebook
lavenzg
force-pushed
the
export-D101879633
branch
2 times, most recently
from
e33e5a1 to
db96246
Compare
lavenzg
force-pushed
the
export-D101879633
branch
from
db96246 to
df12510
Compare
|
@lavenzg has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101879633. |
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Apr 21, 2026
Summary: Pull Request resolved: react#56545 Add */metainternal/* to ReactApple's exclude_patterns in the C++ API snapshot config. This directory may contain internal headers that are not part of the public React Native C++ API surface. Changelog: [Internal] Differential Revision: D101879633
meta-codesync
Bot
changed the title
lavenzg
force-pushed
the
export-D101879633
branch
from
df12510 to
ed30780
Compare
Summary: Add */metainternal/* to top-level exclude_patterns in the C++ API snapshot config. This directory may contain internal headers that are not part of the public React Native C++ API surface. Changelog: [Internal] Differential Revision: D101879633
lavenzg
force-pushed
the
export-D101879633
branch
from
ed30780 to
f8336f7
Compare
cortinico
approved these changes
Apr 22, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @lavenzg in a78d6f4 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in a78d6f4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add /metainternal/ to top-level exclude_patterns in the C++ API snapshot config.
This directory may contain internal headers that are not part of the public React Native
C++ API surface.
Changelog: [Internal]
Differential Revision: D101879633