Remove isHermesV1 from Babel preset (#56754)#56754
Closed
cipolleschi wants to merge 6 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104649639. |
cortinico
approved these changes
May 11, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync
Bot
changed the title
cipolleschi
force-pushed
the
export-D104649639
branch
5 times, most recently
from
dde7574 to
ccaabf1
Compare
…oad the correct commit data. Differential Revision: D104228879
…oad the correct commit data. Differential Revision: D104244582
Summary: Pull Request resolved: #56735 - Remove `RCT_HERMES_V1_ENABLED` environment variable from `react_native_pods.rb` - Simplify `jsengine.rb` to always use `.hermesversion` tag file - Remove conditional `HERMES_V1_ENABLED=1` preprocessor definition from `utils.rb` - Simplify `hermes-engine.podspec`: always read `HERMES_VERSION_NAME`, use V1 source files, remove legacy inspector subspecs - Simplify `hermes-utils.rb`: remove `hermes_v1_enabled()` function, always use `250829098.0.0-stable` branch, always use `.hermesversion` tag file ## Changelog: [iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods ## Test plan - [x] iOS: `bundle exec pod install` — success - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Differential Revision: D104247277 Reviewed By: cortinico
Differential Revision: D104380961
Differential Revision: D104381269
cipolleschi
force-pushed
the
export-D104649639
branch
from
ccaabf1 to
cd17456
Compare
Summary: Pull Request resolved: #56754 Hermes V1 (Static Hermes) is now always enabled. Remove the isHermesV1 variable and inline its effects: - enableRegenerator is always based on dev mode (was isHermesV1 && dev) - preserveClasses is always true (was isHermesV1) Also update the comments to drop the 'V1' framing. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D104649639
cipolleschi
force-pushed
the
export-D104649639
branch
from
cd17456 to
eaca300
Compare
|
This pull request has been merged in 26040d8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Hermes V1 (Static Hermes) is now always enabled. Remove the isHermesV1 variable and inline its effects:
Also update the comments to drop the 'V1' framing.
Changelog:
[Internal] -
Reviewed By: cortinico
Differential Revision: D104649639