Add trace markers in ViewTransitionModule (#56997)#56997
Closed
zeyap wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105214325. |
meta-codesync
Bot
changed the title
zeyap
force-pushed
the
export-D105214325
branch
4 times, most recently
from
cf46b41 to
39800ac
Compare
Summary: ## Changelog: [Internal] [Changed] - Revisit timing to capture old/new nodes Previously, when `applyViewTransitionName` is called from react reconciler, if there is active viewtransition, we decide it's applying to new node. This was incorrect because `applyViewTransitionName(old)` for next transition can be called when the previous transition is still ongoing. In fact `applyViewTransitionName(old)` is guaranteed to be called before mutationCallback in a transition while `applyViewTransitionName(new)` is inside mutationCallback. So that is a better criteria to separate old and new cases. Given mutationCallback is synchronous on JS thread we can just use a boolean flag to tell the timing. Given this interleaved situation, when we clean up resources (for new/old nodes) of a transition at its end, we should also avoid removing those for a pending transition. Introducing transitionId for this case. Reviewed By: Abbondanzo Differential Revision: D105214322
Summary: ## Changelog: [Internal] [Changed] - Add trace markers in ViewTransitionModule Reviewed By: rubennorte Differential Revision: D105214325
Collaborator
|
This pull request was successfully merged by @zeyap in f363f6b When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in f363f6b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Changed] - Add trace markers in ViewTransitionModule
Reviewed By: rubennorte
Differential Revision: D105214325