Remove unused bridge-based RCTTurboModuleManager initializer (#57065)#57065
Closed
christophpurrer wants to merge 1 commit into
Closed
Remove unused bridge-based RCTTurboModuleManager initializer (#57065)#57065christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107409088. |
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
…7065) Summary: ## Changelog: [iOS][Breaking] Remove unused bridge-based RCTTurboModuleManager initializer `RCTTurboModuleManager` declared three initializers, but only the bridgeless (`RCTBridgeProxy`-based) ones are used. The bridge-based `initWithBridge:delegate:jsInvoker:` initializer was the only path that ever set a non-nil bridge, leaving a large amount of bridge-only code permanently dead under the surviving initializers. This removes that initializer along with the now-dead bridge-mode code: the `_bridge` ivar, the `decorateNativeMethodCallInvoker:` decoration, the `RCTModuleData`/`registerModuleForFrameUpdates:` registration, the `performanceLogger` setup markers, and the bridge invalidation notification observers and handlers. `initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:` becomes the designated initializer, and the shorter `RCTBridgeProxy` initializer now forwards to it. The `RCTDidInitializeModuleNotification` post is preserved with a nil bridge, matching the existing runtime behaviour of the bridgeless initializers. Differential Revision: D107409088
christophpurrer
force-pushed
the
export-D107409088
branch
from
e152ad1 to
6defe41
Compare
…7065) Summary: ## Changelog: [iOS][Breaking] Remove unused bridge-based RCTTurboModuleManager initializer `RCTTurboModuleManager` declared three initializers, but only the bridgeless (`RCTBridgeProxy`-based) ones are used. The bridge-based `initWithBridge:delegate:jsInvoker:` initializer was the only path that ever set a non-nil bridge, leaving a large amount of bridge-only code permanently dead under the surviving initializers. This removes that initializer along with the now-dead bridge-mode code: the `_bridge` ivar, the `decorateNativeMethodCallInvoker:` decoration, the `RCTModuleData`/`registerModuleForFrameUpdates:` registration, the `performanceLogger` setup markers, and the bridge invalidation notification observers and handlers. `initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:` becomes the designated initializer, and the shorter `RCTBridgeProxy` initializer now forwards to it. The `RCTDidInitializeModuleNotification` post is preserved with a nil bridge, matching the existing runtime behaviour of the bridgeless initializers. Differential Revision: D107409088
christophpurrer
force-pushed
the
export-D107409088
branch
from
6defe41 to
f0d6309
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
…7065) Summary: ## Changelog: [iOS][Breaking] Remove unused bridge-based RCTTurboModuleManager initializer `RCTTurboModuleManager` declared three initializers, but only the bridgeless (`RCTBridgeProxy`-based) ones are used. The bridge-based `initWithBridge:delegate:jsInvoker:` initializer was the only path that ever set a non-nil bridge, leaving a large amount of bridge-only code permanently dead under the surviving initializers. This removes that initializer along with the now-dead bridge-mode code: the `_bridge` ivar, the `decorateNativeMethodCallInvoker:` decoration, the `RCTModuleData`/`registerModuleForFrameUpdates:` registration, the `performanceLogger` setup markers, and the bridge invalidation notification observers and handlers. `initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:` becomes the designated initializer, and the shorter `RCTBridgeProxy` initializer now forwards to it. The `RCTDidInitializeModuleNotification` post is preserved with a nil bridge, matching the existing runtime behaviour of the bridgeless initializers. Reviewed By: philIip Differential Revision: D107409088
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 3, 2026
…7065) Summary: ## Changelog: [iOS][Breaking] Remove unused bridge-based RCTTurboModuleManager initializer `RCTTurboModuleManager` declared three initializers, but only the bridgeless (`RCTBridgeProxy`-based) ones are used. The bridge-based `initWithBridge:delegate:jsInvoker:` initializer was the only path that ever set a non-nil bridge, leaving a large amount of bridge-only code permanently dead under the surviving initializers. This removes that initializer along with the now-dead bridge-mode code: the `_bridge` ivar, the `decorateNativeMethodCallInvoker:` decoration, the `RCTModuleData`/`registerModuleForFrameUpdates:` registration, the `performanceLogger` setup markers, and the bridge invalidation notification observers and handlers. `initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:` becomes the designated initializer, and the shorter `RCTBridgeProxy` initializer now forwards to it. The `RCTDidInitializeModuleNotification` post is preserved with a nil bridge, matching the existing runtime behaviour of the bridgeless initializers. Reviewed By: philIip Differential Revision: D107409088
|
This pull request has been merged in cb74b82. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in cb74b82 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[iOS][Breaking] Remove unused bridge-based RCTTurboModuleManager initializer
RCTTurboModuleManagerdeclared three initializers, but only the bridgeless (RCTBridgeProxy-based) ones are used. The bridge-basedinitWithBridge:delegate:jsInvoker:initializer was the only path that ever set a non-nil bridge, leaving a large amount of bridge-only code permanently dead under the surviving initializers.This removes that initializer along with the now-dead bridge-mode code: the
_bridgeivar, thedecorateNativeMethodCallInvoker:decoration, theRCTModuleData/registerModuleForFrameUpdates:registration, theperformanceLoggersetup markers, and the bridge invalidation notification observers and handlers.initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:becomes the designated initializer, and the shorterRCTBridgeProxyinitializer now forwards to it. TheRCTDidInitializeModuleNotificationpost is preserved with a nil bridge, matching the existing runtime behaviour of the bridgeless initializers.Differential Revision: D107409088