Skip to content

Remove dead JSIndexedRAMBundle from cxxreact (#57133) #57133

Open
sammy-SC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dead JSIndexedRAMBundle from cxxreact (#57133) #57133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions packages/react-native/ReactCommon/cxxreact/Instance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "RecoverableError.h"
#include "TraceSection.h"

#include <cxxreact/JSIndexedRAMBundle.h>
#include <folly/json.h>
#include <react/debug/react_native_assert.h>

Expand Down Expand Up @@ -175,30 +174,6 @@ void Instance::loadScriptFromString(
}
}

void Instance::loadRAMBundleFromString(
std::unique_ptr<const JSBigString> script,
const std::string& sourceURL) {
auto bundle = std::make_unique<JSIndexedRAMBundle>(std::move(script));
auto startupScript = bundle->getStartupCode();
auto registry = RAMBundleRegistry::singleBundleRegistry(std::move(bundle));
loadRAMBundle(std::move(registry), std::move(startupScript), sourceURL, true);
}

void Instance::loadRAMBundleFromFile(
const std::string& sourcePath,
const std::string& sourceURL,
bool loadSynchronously) {
auto bundle = std::make_unique<JSIndexedRAMBundle>(sourcePath.c_str());
auto startupScript = bundle->getStartupCode();
auto registry = RAMBundleRegistry::multipleBundlesRegistry(
std::move(bundle), JSIndexedRAMBundle::buildFactory());
loadRAMBundle(
std::move(registry),
std::move(startupScript),
sourceURL,
loadSynchronously);
}

void Instance::loadRAMBundle(
std::unique_ptr<RAMBundleRegistry> bundleRegistry,
std::unique_ptr<const JSBigString> startupScript,
Expand Down
2 changes: 0 additions & 2 deletions packages/react-native/ReactCommon/cxxreact/Instance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ class RN_EXPORT [[deprecated("This API will be removed along with the legacy arc
void setSourceURL(std::string sourceURL);

void loadScriptFromString(std::unique_ptr<const JSBigString> string, std::string sourceURL, bool loadSynchronously);
void loadRAMBundleFromString(std::unique_ptr<const JSBigString> script, const std::string &sourceURL);
void loadRAMBundleFromFile(const std::string &sourcePath, const std::string &sourceURL, bool loadSynchronously);
void loadRAMBundle(
std::unique_ptr<RAMBundleRegistry> bundleRegistry,
std::unique_ptr<const JSBigString> startupScript,
Expand Down
145 changes: 0 additions & 145 deletions packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.cpp
View file
Open in desktop

This file was deleted.

72 changes: 0 additions & 72 deletions packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions packages/react-native/ReactCommon/cxxreact/tests/JSIndexedRAMBundleTest.cpp
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2727,8 +2727,6 @@ class facebook::react::Instance {
public void initializeBridge(std::unique_ptr<facebook::react::InstanceCallback> callback, std::shared_ptr<facebook::react::JSExecutorFactory> jsef, std::shared_ptr<facebook::react::MessageQueueThread> jsQueue, std::shared_ptr<facebook::react::ModuleRegistry> moduleRegistry, facebook::react::jsinspector_modern::HostTarget* inspectorTarget = nullptr);
public void initializeRuntime();
public void loadRAMBundle(std::unique_ptr<facebook::react::RAMBundleRegistry> bundleRegistry, std::unique_ptr<const facebook::react::JSBigString> startupScript, std::string startupScriptSourceURL, bool loadSynchronously);
public void loadRAMBundleFromFile(const std::string& sourcePath, const std::string& sourceURL, bool loadSynchronously);
public void loadRAMBundleFromString(std::unique_ptr<const facebook::react::JSBigString> script, const std::string& sourceURL);
public void loadScriptFromString(std::unique_ptr<const facebook::react::JSBigString> string, std::string sourceURL, bool loadSynchronously);
public void registerBundle(uint32_t bundleId, const std::string& bundlePath);
public void setGlobalVariable(std::string propName, std::unique_ptr<const facebook::react::JSBigString> jsonValue);
Expand Down Expand Up @@ -3004,14 +3002,6 @@ class facebook::react::JSINativeModules {
public void reset();
}

class facebook::react::JSIndexedRAMBundle : public facebook::react::JSModulesUnbundle {
public JSIndexedRAMBundle(const char* sourcePath);
public JSIndexedRAMBundle(std::unique_ptr<const facebook::react::JSBigString> script);
public static std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> buildFactory();
public std::unique_ptr<const facebook::react::JSBigString> getStartupCode();
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const override;
}

class facebook::react::JSModulesUnbundle {
public JSModulesUnbundle();
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const = 0;
Expand Down
10 changes: 0 additions & 10 deletions scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2724,8 +2724,6 @@ class facebook::react::Instance {
public void initializeBridge(std::unique_ptr<facebook::react::InstanceCallback> callback, std::shared_ptr<facebook::react::JSExecutorFactory> jsef, std::shared_ptr<facebook::react::MessageQueueThread> jsQueue, std::shared_ptr<facebook::react::ModuleRegistry> moduleRegistry, facebook::react::jsinspector_modern::HostTarget* inspectorTarget = nullptr);
public void initializeRuntime();
public void loadRAMBundle(std::unique_ptr<facebook::react::RAMBundleRegistry> bundleRegistry, std::unique_ptr<const facebook::react::JSBigString> startupScript, std::string startupScriptSourceURL, bool loadSynchronously);
public void loadRAMBundleFromFile(const std::string& sourcePath, const std::string& sourceURL, bool loadSynchronously);
public void loadRAMBundleFromString(std::unique_ptr<const facebook::react::JSBigString> script, const std::string& sourceURL);
public void loadScriptFromString(std::unique_ptr<const facebook::react::JSBigString> string, std::string sourceURL, bool loadSynchronously);
public void registerBundle(uint32_t bundleId, const std::string& bundlePath);
public void setGlobalVariable(std::string propName, std::unique_ptr<const facebook::react::JSBigString> jsonValue);
Expand Down Expand Up @@ -3001,14 +2999,6 @@ class facebook::react::JSINativeModules {
public void reset();
}

class facebook::react::JSIndexedRAMBundle : public facebook::react::JSModulesUnbundle {
public JSIndexedRAMBundle(const char* sourcePath);
public JSIndexedRAMBundle(std::unique_ptr<const facebook::react::JSBigString> script);
public static std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> buildFactory();
public std::unique_ptr<const facebook::react::JSBigString> getStartupCode();
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const override;
}

class facebook::react::JSModulesUnbundle {
public JSModulesUnbundle();
public virtual facebook::react::JSModulesUnbundle::Module getModule(uint32_t moduleId) const = 0;
Expand Down
Loading
Loading