Skip to content

Allow outline* styles on stable React Native #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MoOx wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −16
Open

Allow outline* styles on stable React Native #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions packages/react-strict-dom/src/native/css/isAllowedStyleKey.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
* @flow strict
*/

import { version } from '../modules/version';

const allowedStyleKeySet = new Set<string>([
'alignContent',
'alignItems',
Expand Down Expand Up @@ -122,6 +120,10 @@ const allowedStyleKeySet = new Set<string>([
'mixBlendMode',
'objectFit',
'opacity',
'outlineColor',
'outlineOffset',
'outlineStyle',
'outlineWidth',
Comment on lines +123 to +126
'overflow',
'padding',
'paddingBlock',
Expand Down Expand Up @@ -167,13 +169,6 @@ const allowedStyleKeySet = new Set<string>([
'::placeholder'
]);

if (version.experimental) {
allowedStyleKeySet.add('outlineColor');
allowedStyleKeySet.add('outlineOffset');
allowedStyleKeySet.add('outlineStyle');
allowedStyleKeySet.add('outlineWidth');
}

export function isAllowedStyleKey(key: string): boolean {
return (
allowedStyleKeySet.has(key) ||
Expand Down
9 changes: 2 additions & 7 deletions packages/react-strict-dom/src/native/css/isLengthStyleKey.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
* @flow strict
*/

import { version } from '../modules/version';

export const lengthStyleKeySet: Set<string> = new Set([
'blockSize',
'borderBottomLeftRadius',
Expand Down Expand Up @@ -65,6 +63,8 @@ export const lengthStyleKeySet: Set<string> = new Set([
'minHeight',
'minInlineSize',
'minWidth',
'outlineOffset',
'outlineWidth',
Comment on lines +66 to +67
'padding',
'paddingBlock',
'paddingBlockEnd',
Expand All @@ -81,8 +81,3 @@ export const lengthStyleKeySet: Set<string> = new Set([
'top',
'width'
]);

if (version.experimental) {
lengthStyleKeySet.add('outlineOffset');
lengthStyleKeySet.add('outlineWidth');
}
Loading