Skip to content

Initial Kotlin setup and migrate YogaConstants#1829

Closed
mateoguzmana wants to merge 2 commits into
react:mainfrom
mateoguzmana:feat/initial-setup-for-kotlin
Closed

Initial Kotlin setup and migrate YogaConstants#1829
mateoguzmana wants to merge 2 commits into
react:mainfrom
mateoguzmana:feat/initial-setup-for-kotlin

Conversation

@mateoguzmana

@mateoguzmana mateoguzmana commented Aug 2, 2025

Copy link
Copy Markdown
Contributor

As part of the ongoing effort to migrate the React Native codebase to Kotlin, this PR introduces the initial setup required for Kotlin support in Yoga.

  • Added initial basic Kotlin configuration to the project.
  • Migrated YogaConstants as an initial file to try out the first migration steps.

Test plan:

  • Tested the migrated class directly against facebook/react-native, see the PR here.
  • Run: ./gradlew :yoga:assembleDebug & ./gradlew :yoga:compileDebugSources

I am not able to run the Java tests in this repo (even before the initial Kotlin setup) – not sure if I am missing something there but any pointers are welcome – it seems like there is some missing configuration. Currently trying with ./gradlew :yoga:test

@vercel

vercel Bot commented Aug 2, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 3:46pm

@meta-cla meta-cla Bot added the CLA Signed label Aug 2, 2025
@mateoguzmana mateoguzmana force-pushed the feat/initial-setup-for-kotlin branch 2 times, most recently from a982cd5 to 4a6ef8f Compare August 2, 2025 12:38
@mateoguzmana mateoguzmana force-pushed the feat/initial-setup-for-kotlin branch from 4a6ef8f to 42ff80b Compare August 2, 2025 12:53
@mateoguzmana mateoguzmana marked this pull request as ready for review August 4, 2025 07:07
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 4, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this in D79545992.

Comment thread build.gradle Outdated
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this in D79545992.

@mateoguzmana mateoguzmana requested a review from cortinico August 4, 2025 16:10
rshest pushed a commit to rshest/react-native that referenced this pull request Aug 7, 2025
Summary:
# Changelog:
[Internal] -

As part of the ongoing effort to migrate the React Native codebase to Kotlin, this PR introduces the initial setup required for Kotlin support in Yoga.

- Added initial basic Kotlin configuration to the project.
- Migrated `YogaConstants` as an initial file to try out the first migration steps.

X-link: react/yoga#1829

Reviewed By: cortinico

Differential Revision: D79545992

Pulled By: rshest
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@rshest merged this pull request in 8bf7a34.

facebook-github-bot pushed a commit to react/react-native that referenced this pull request Aug 7, 2025
Summary:
Pull Request resolved: #53133

# Changelog:
[Internal] -

As part of the ongoing effort to migrate the React Native codebase to Kotlin, this PR introduces the initial setup required for Kotlin support in Yoga.

- Added initial basic Kotlin configuration to the project.
- Migrated `YogaConstants` as an initial file to try out the first migration steps.

X-link: react/yoga#1829

Test Plan:
- Tested the migrated class directly against facebook/react-native, see the PR [here](#52998).
- Run: `./gradlew :yoga:assembleDebug` & `./gradlew :yoga:compileDebugSources`

I am not able to run the Java tests in this repo (even before the initial Kotlin setup) – not sure if I am missing something there but any pointers are welcome – it seems like there is some missing configuration. Currently trying with `./gradlew :yoga:test`

Reviewed By: cortinico

Differential Revision: D79545992

Pulled By: rshest

fbshipit-source-id: 8257ff53e6b6f2436980be98b6c94e1ac526b207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Merged Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants