Fix MissingOverrideAnnotation: Add @Override to YogaNodeJNIBase methods (#1918)#1918
Closed
mdvacca wants to merge 1 commit into
Closed
Fix MissingOverrideAnnotation: Add @Override to YogaNodeJNIBase methods (#1918)#1918mdvacca wants to merge 1 commit into
mdvacca wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mdvacca
force-pushed
the
export-D95413075
branch
from
8db246c to
df34ca3
Compare
cortinico
approved these changes
Apr 6, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
mdvacca
force-pushed
the
export-D95413075
branch
from
df34ca3 to
a308fa3
Compare
…ds (facebook#1918) Summary: Pull Request resolved: facebook#1918 X-link: facebook/react-native#56040 Fixed 101 MissingOverrideAnnotation lint errors in YogaNodeJNIBase.java. Added Override annotation to all public methods that override abstract methods from the YogaNode superclass but were missing the annotation. This includes style getters/setters (direction, flex, margin, padding, border, position, width, height, min/max dimensions, aspect ratio, gap), layout methods (reset, calculateLayout, dirty), tree manipulation (addChildAt, removeChildAt, indexOf), and measurement/baseline functions. Changelog: [Internal] internal Reviewed By: cortinico Differential Revision: D95413075
meta-codesync
Bot
changed the title
mdvacca
force-pushed
the
export-D95413075
branch
from
a308fa3 to
493c508
Compare
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
Apr 6, 2026
…ds (#56040) Summary: X-link: react/yoga#1918 Pull Request resolved: #56040 Fixed 101 MissingOverrideAnnotation lint errors in YogaNodeJNIBase.java. Added Override annotation to all public methods that override abstract methods from the YogaNode superclass but were missing the annotation. This includes style getters/setters (direction, flex, margin, padding, border, position, width, height, min/max dimensions, aspect ratio, gap), layout methods (reset, calculateLayout, dirty), tree manipulation (addChildAt, removeChildAt, indexOf), and measurement/baseline functions. Changelog: [Internal] internal Reviewed By: cortinico Differential Revision: D95413075 fbshipit-source-id: fc148c8aefe734c090541b6eb02815c1446d2e98
|
This pull request has been merged in 110ca9e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#56040
Fixed 101 MissingOverrideAnnotation lint errors in YogaNodeJNIBase.java.
Added Override annotation to all public methods that override abstract methods from the YogaNode superclass but were missing the annotation. This includes style getters/setters (direction, flex, margin, padding, border, position, width, height, min/max dimensions, aspect ratio, gap), layout methods (reset, calculateLayout, dirty), tree manipulation (addChildAt, removeChildAt, indexOf), and measurement/baseline functions.
Changelog: [Internal] internal
Reviewed By: cortinico
Differential Revision: D95413075