Migrate YogaPositionType enum to Kotlin#1945
Closed
cortinico wants to merge 17 commits into
Closed
Conversation
Summary: Migrate all hand-written Java test files in xplat/yoga/java/tests/ to Kotlin as part of the Yoga Java-to-Kotlin migration effort. Also updates the BUCK test target glob to include *.kt files. Files migrated: TestParametrization.java, utils/TestUtils.java, YogaValueTest.java, YogaLoggerTest.java, YGAlignBaselineTest.java, YogaExceptionTest.java, YogaNodeTest.java, YogaNodeStylePropertiesTest.java. Changelog: [Internal] - Differential Revision: D104666348
Summary: Migrate YogaAlign.java to YogaAlign.kt by adding Align to KOTLIN_ENUM_NAMES in enums.py and regenerating. Changelog: [Internal] - Differential Revision: D104666334
Summary: Migrate YogaBoxSizing.java to YogaBoxSizing.kt by adding BoxSizing to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666350
Summary: Migrate YogaDimension.java to YogaDimension.kt by adding Dimension to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666342
Summary: Migrate YogaDisplay.java to YogaDisplay.kt by adding Display to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666346
Summary: Migrate YogaEdge.java to YogaEdge.kt by adding Edge to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666351
Summary: Migrate YogaErrata.java to YogaErrata.kt by adding Errata to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666332
Summary: Migrate YogaExperimentalFeature.java to YogaExperimentalFeature.kt by adding ExperimentalFeature to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666330
Summary: Migrate YogaFlexDirection.java to YogaFlexDirection.kt by adding FlexDirection to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666341
Summary: Migrate YogaGridTrackType.java to YogaGridTrackType.kt by adding GridTrackType to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666336
Summary: Migrate YogaGutter.java to YogaGutter.kt by adding Gutter to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666345
Summary: Migrate YogaJustify.java to YogaJustify.kt by adding Justify to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666331
Summary: Migrate YogaLogLevel.java to YogaLogLevel.kt by adding LogLevel to KOTLIN_ENUM_NAMES in enums.py and regenerating. Also adds DO_NOT_STRIP support to the Kotlin codegen path to preserve the DoNotStrip annotation. Differential Revision: D104666343
Summary: Migrate YogaMeasureMode.java to YogaMeasureMode.kt by adding MeasureMode to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666333
Summary: Migrate YogaNodeType.java to YogaNodeType.kt by adding NodeType to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666338
Summary: Migrate YogaOverflow.java to YogaOverflow.kt by adding Overflow to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666340
Summary: X-link: react/react-native#56789 Migrate YogaPositionType.java to YogaPositionType.kt by adding PositionType to KOTLIN_ENUM_NAMES in enums.py and regenerating. Differential Revision: D104666349
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104666349. |
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
May 13, 2026
Summary: X-link: react/yoga#1945 Pull Request resolved: #56789 Migrate YogaPositionType.java to YogaPositionType.kt by adding PositionType to KOTLIN_ENUM_NAMES in enums.py and regenerating. Reviewed By: fabriziocucci Differential Revision: D104666349 fbshipit-source-id: 7f81f15000f561fc11283313f74b4ae3112c2f75
|
This pull request has been merged in 78aac51. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: react/react-native#56789
Migrate YogaPositionType.java to YogaPositionType.kt by adding PositionType to KOTLIN_ENUM_NAMES in enums.py and regenerating.
Differential Revision: D104666349