Display joins/nicks/parts/quits in single Discord channel#515
Open
calebmckay wants to merge 8 commits intoreactiflux:mainfrom
Open
Display joins/nicks/parts/quits in single Discord channel#515calebmckay wants to merge 8 commits intoreactiflux:mainfrom
calebmckay wants to merge 8 commits intoreactiflux:mainfrom
Conversation
…o display joins/quits
…annel. Update README with new configuration option.
Collaborator
|
Hey! I'm sorry it took me so long to respond to this: I'm probably not going to be reviewing this or merging it anytime soon, as I'm only now maintaining discord-irc for bug fixes and vulnerabilities. (I'm no longer an active user of the project.) I appreciate the contribution anyway, and hopefully it will be useful to people who come across it! If you have the time to maintain a fork, that might be a way to help keep this project going. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run a Discord server that maps to 3 IRC channels. When a user joins IRC, they're automatically joined to all 3 channels. Discord users were frustrated when they saw alerts for new messages across 3 channels for a single user joining/quitting.
This pull request expands the functionality of
ircStatusNoticesin the config to allow users to specify a string value, representing a single Discord channel to display all joins, nick changes, parts, and quits. These messages will display once for each join/nick/quit (no matter how many channels the change is affecting), and display all parts along with the channel name affected.