Add setting to disable IRC- and/or Discord-style mentions

[Gargaj]

This fixes #528 which is really annoying.

[coveralls]

Coverage increased (+0.04%) to 97.175% when pulling 816c3db on Gargaj:master into 41f8444 on reactiflux:master.

[Gargaj]

@CVSoft in case you still need it

[Gargaj]

@Throne3d I know you no longer add code, but this is merge-ready, if you want :)

[SparxySys]

This seems simple enough for me - if there is enough interest it should probably be merged, although I'm not really a fan of the names of the new config options.

You should, however, update the README as well, advanced options under Example configuration.

[Gargaj]

I admit I struggled with the option names; suggestions welcome? :/

[SparxySys]

Naming wise, try to KISS: it could be as simple as allowMentionsWithAtPrefix and allowMentionsWithoutPrefix.

However, those names have made me start thinking and propose an alternate solution. I would love your input.

(This does not mean I do not approve of your current PR, it solves a problem aptly).

This is what this current PR does:

The problem you want to solve is:

• Currently, the bot will try to resolve mentions even for normal words because mentions require no prefix

Your solutioning is:

• Introduce a configuration setting to disable mentions without a prefix

As a nice-to-have that matches with it:

• Introduce a configuration setting to disable mentions with a prefix.

Possible alternative solution

Now, I'm just going to 'go wild' here and toss out a different possible approach - I would like your input on it as well:
Problem:

• The bot will resolve who to mention on words without a prefix, and words with prefix @, and this cannot be changed

Proposed solutioning

• Allow the configuration of prefixes that are used to resolve mentions.

I would imagine the default configuration could look something like this:

{
    "mentionPrefixes": [
        "",
        "@"
    ]
}

Conclusion

Just some food for thought. This would offer a lot more flexibility in the configuration instead of creating a hard-coded case for every commonly-asked for (combination of..) prefixes (or lack thereof) to mention people with.

[Gargaj]

The problem is that "prefix" is misleading, the format it's using isn't just @nick, but also nick: and nick,.

[Gargaj]

Perhaps instead of mentionPrefixes it should be mentionRegexps?

[jesigloot]

To throw my apprecation into this; Needed exactly this feature, so compiled it into a docker image myself to run it. 😅

[Throne3d]

Hey! Sorry to not have responded in a while – I haven't been tracking this repository very well.

I really appreciate the contribution, especially the added tests. I see that there's still some open discussion here, so I'm not going to merge it immediately. (I know it's not a huge difference either way, but still.) If this comes to a consensus I can try to get to merging it then!

[Gargaj]

For what it's worth we've been running with this for one of our bots and it's working brilliantly.