fix: support connection_pool v3#1367
Merged
Merged
Conversation
|
Thanks @G-Rath. Came here for the same issue and was happy to see your PR. |
|
Any updates on when this can be merged? |
G-Rath
added a commit
to ackama/rails-template
that referenced
this pull request
Dec 11, 2025
Currently `react-rails` does not work with `connection_pool` v3, so we need to lock to v2 until reactjs/react-rails#1367 is released
justin808
pushed a commit
that referenced
this pull request
Dec 12, 2025
* test: add appraisal gemfile for `connection_pool` v2 * test: add coverage for `connection_pool` v3 * fix: support `connection_pool` v3 * docs: add changelog entry * refactor simplify fix
|
thanks @G-Rath @justin808 any plans for doing a release? thanks |
|
Aloha @justin808! Any chances of you gifting us a release for Christmas? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connection_poolv3+ requires keyword arguments instead of positional args, but also drops support for Ruby 3.2 so this has us check the version being used and do the right thing accordinglyOther Information
Resolves #1366
Pull Request checklist
Update documentation