Open
Conversation
reblws
approved these changes
Feb 13, 2020
Owner
reblws
left a comment
reblws
left a comment
There was a problem hiding this comment.
Looks good, I'll put this in for 0.4.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't run a search query on an empty string.
This removes an unnecessary search before the user types their query,
which is slow (edit: about 3 seconds) for my ~800 tabs over 2 windows (on x64 Firefox 66, Debian-flavour Linux).
Reduces the time-to-search when opening the popup window.
(I literally just moved the curly brace for the else statement on
isSearchEmpty, indented the query block, and added a comment about this).