Added missing previous selection discard upon the new selection change#155
Merged
rsimon merged 2 commits intorecogito:mainfrom Oct 14, 2024
Merged
Conversation
Comment on lines
209
to
214
| } | ||
| } else if (!selection.isEmpty()) { | ||
| } else { | ||
| selection.clear(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The isEmpty check is redundant because such a case is already handled on the a9s side. The operation will be no-op if the selection is already clear. Source
Member
|
Thanks - yes, that makes sense. The previous selection should clear as soon as you start the next, not after you complete it. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
|
Another mobile quirk! Screen.Recording.2024-10-16.at.21.33.21.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Initially reported - #151 (comment)
Can be reproduced in the playground:
selected_still.mp4