Harden navbar external links - #205
Merged
Merged
Conversation
dextmorgn
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two external links in the dashboard navbar open with
target="_blank"but do not set arelattribute. Other external links in the app already userel="noopener noreferrer", so these two were inconsistent with the safer pattern.Before / after
Before, the GitHub and Support dropdown links opened a new tab without explicitly isolating the opener context.
After, both links include
rel="noopener noreferrer", matching the rest of the app's external-link handling.Verification
../node_modules/.bin/prettier.cmd --check src/components/layout/top-navbar.tsxgit diff --checkI also tried
npm run typecheck, but it currently fails on unrelated existing TypeScript errors across the app, including missing@tiptap/react/menus, missing@tiptap/markdown, and several pre-existing implicit-any/unused import errors outside this navbar file.