Skip to content

Extract constant SLEEP_STEP_USEC #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbellettini merged 2 commits into from
Aug 2, 2025
Merged

Extract constant SLEEP_STEP_USEC #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cccc95
Extract constant SLEEP_STEP_USEC
dbellettini Aug 2, 2025
58cc1ac
Increase SLEEP_STEP_USEC to 200ms
dbellettini Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Command/RobustCommandRunner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
class RobustCommandRunner extends Command
{
private const int CYCLES_BEFORE_GC = 100;
private const int SLEEP_STEP_USEC = 200000;

private const string LEADERSHIP_STATUS_ACQUIRED = 'acquired';
private const string LEADERSHIP_STATUS_LOST = 'lost';
Expand Down Expand Up @@ -140,8 +141,8 @@ private function askedToStop(): bool
private function sleepIfNotAskedToStop(int $milliSeconds): bool
{
$microSeconds = $milliSeconds * 1000;
for ($i = 0; $i < $microSeconds && !$this->askedToStop(); $i += 50000) {
usleep(50000);
for ($i = 0; $i < $microSeconds && !$this->askedToStop(); $i += self::SLEEP_STEP_USEC) {
usleep(self::SLEEP_STEP_USEC);
}

return $this->askedToStop();
Expand Down