Winston/tasks - #292
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request restructures web scraping and SEO functionality by consolidating crawler packages, introducing new task infrastructure, and creating a dedicated SEO application with comprehensive marketing components.
Key changes:
- Refactors crawler functionality from a standalone package to a unified task system
- Creates a new SEO application with complete marketing website infrastructure
- Migrates TypeScript targets from ES2024 to ESNext for broader compatibility
Reviewed Changes
Copilot reviewed 76 out of 87 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tooling/typescript/tsconfig.base.json | Updates TypeScript target and lib from ES2024 to ESNext |
| packages/task/* | New task package replacing crawler with Trigger.dev integration and enhanced content extraction |
| packages/crawler/* | Removes old crawler package files and configurations |
| apps/seo/* | Complete new SEO application with marketing pages, authentication, and onboarding flows |
| .github/workflows/cloudflare.yml | Adds SEO app deployment pipeline |
commit: |
Contributor
|
Cloudflare Preview URL for WWW 🎈 : https://pr-292.rectangularlabs.com (custom domain) |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 124 out of 146 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
packages/task/src/trigger/understand-site.ts:1
- Using
process.exit(1)in a catch block will terminate the entire process abruptly. This prevents proper cleanup and error handling. Consider throwing an error or returning an error result instead.
import { google } from "@ai-sdk/google";
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 124 out of 146 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (2)
packages/task/src/trigger/understand-site.ts:1
- Using
process.exit(1)in a catch block is problematic as it abruptly terminates the entire process without proper cleanup. Consider throwing an error or returning a failure result instead to allow proper error handling by the calling code.
import { google } from "@ai-sdk/google";
packages/task/src/lib/extract-sitemap-urls.ts:1
- The JSDoc comment has an empty description line and uses JavaScript-style parameter documentation in a TypeScript file. Either provide a meaningful description or remove the empty line, and consider using TypeScript-style documentation.
import { log, RobotsTxtFile } from "crawlee";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.