Make PHPStan DI-Container available in bootstrap files#8190
Merged
Conversation
samsonasik
reviewed
Jul 16, 2026
staabm
marked this pull request as ready for review
July 16, 2026 12:00
Contributor
Author
|
@TomasVotruba should be ready to review |
samsonasik
reviewed
Jul 17, 2026
| } | ||
|
|
||
| require $bootstrapFile; | ||
| // mimic PHPStan bootstrap file inclusion (bootstrap files have access to the global $container variable) |
Member
There was a problem hiding this comment.
imo, I am thinking if this can be configurable via RectorConfig/RectorConfigBuilder, eg: enableForwardPHPStanBootstrap() config, whether it enable by default or not is fine, but should be configurable.
Contributor
Author
There was a problem hiding this comment.
I am not sure whether hiding this "feature" behind a feature-flag is a good idea. @TomasVotruba wdyt?
Member
There was a problem hiding this comment.
Let's keep it simple and compatible with PHPStan way 👍
Member
|
Thank you, I'll merge this to give it roun of testing for edge cases 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes rectorphp/rector#9818