Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "good-env",
"version": "7.6.1",
"version": "7.6.2",
"description": "Better environment variable handling for Twelve-Factor node apps",
"main": "src/index.js",
"scripts": {
Expand Down
11 changes: 3 additions & 8 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -331,14 +331,9 @@ module.exports = Object
*/
getNumber (key, defaultVal) {
const value = this.get(key, defaultVal);
const intVal = parseInt(value, 10);
const valIsInt = Number.isInteger(intVal);

if (value === defaultVal) {
return value;
} else if (valIsInt) {
return intVal;
}
if (value === defaultVal) return value;
const num = parseFloat(value);
if (!isNaN(num)) return num;
},

/**
Expand Down
1 change: 1 addition & 0 deletions test/test.env
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
FOO=bar
BANG=boop
INT_NUM=10
FLOAT_NUM=3.14
MY_LIST=foo ,bar,beep
MY_TRUE_KEY=true
MY_FALSE_KEY=false
Expand Down
12 changes: 12 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,18 @@ test('returns integers', (t) => {
t.end();
});

test('returns floats', (t) => {
let result = env.getNumber('FLOAT_NUM');
t.equals(result, 3.14);
result = null;
result = env.num('FLOAT_NUM');
t.equals(result, 3.14);
result = null;
result = env.num(['INTT', 'FLOAT_NUM']);
t.equals(result, 3.14);
t.end();
});

test('returns undefined for non-exequalsting number', (t) => {
const result = env.getNumber('INT_NOT_HERE');
t.equals(undefined, result);
Expand Down
Loading