Add sdk-wrapper for ListPageFilter (error boundary) and useModal (deferred launch) - #2744
Conversation
|
/cherry-pick release-4.22 |
|
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.21-compatibility |
|
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test odf-console-e2e-aws |
04b1996
into
red-hat-storage:master
|
@SanjalKatiyar: new pull request created: #2799 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@SanjalKatiyar: #2744 failed to apply on top of branch "release-4.21-compatibility": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://redhat.atlassian.net/browse/DFBUGS-6713
https://redhat.atlassian.net/browse/DFBUGS-6698
https://redhat.atlassian.net/browse/DFBUGS-6546
When the modal is launched (issue is prominent when it's lazy-loaded), it's crashing PF's
ToolbarFilter(we don't useToolbarFilterdirectly, it's internally used by console'sListPageFiltercomponent which we import). Please check: patternfly/patternfly-react#12352 for more details.As a temporary fix, added a wrapper around the
useModallauncher, a slight delay before opening the modal preventing any interference with theToolbarFilter(orListPageFilter) ongoing lifecycle (eg: unmounting).Also, added an error boundary around
ListPageFilteras a safety measure, in rare case if crash still happens it will silently remove the filter instead of displaying error or breaking the page.More permanent and better fix will be to:
6.4.3or newer (https://github.com/openshift/console/blob/release-4.22/frontend/package.json#L158).ListPageFilterwhich is now a deprecated component (https://github.com/openshift/console/blob/release-4.22/frontend/packages/console-dynamic-plugin-sdk/release-notes/4.19.md?plain=1#L16).