fix for camera select clearing on publisher source.#248
Open
bustardcelly wants to merge 2 commits intomasterfrom
Open
fix for camera select clearing on publisher source.#248bustardcelly wants to merge 2 commits intomasterfrom
bustardcelly wants to merge 2 commits intomasterfrom
Conversation
Contributor
bustardcelly
commented
Jun 7, 2019
bustardcelly
commented
- clear out mediatracks on unpublish in camera select examples.
Contributor
Author
|
The issue was that the MediaTrack for the camera was not being properly cleared on some Mobile Device + Browsers. Upon unpublish (which is invoked when switching cameras and starting a new broadcast), I added code to remove the previous Tests affected:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.