refactor!: move addon config/order from database to filesystem#6528
Merged
Conversation
Store addon install/status and load order in `data/core/addons.json` instead of the `rex_config` database table. This decouples addon state from the database, simplifying deployments and paving the way for deeper Composer integration. - Add `AddonManager::getAddonConfig()` / `getAddonOrder()` reading from `addons.json` - Add `AddonManager::saveAddonsData()` with optional `config`/`order` params - Rename `AddonManager::generatePackageOrder()` to `generateAddonOrder()` - Remove `Core::getPackageConfig()` / `Core::getPackageOrder()` (moved to AddonManager) - Remove unused `$generatePackageOrder` property - Add rector rules for the renamed static methods BREAKING CHANGE: `Core::getPackageConfig()` and `Core::getPackageOrder()` have been moved to `AddonManager::getAddonConfig()` and `AddonManager::getAddonOrder()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store addon install/status and load order in
data/core/addons.jsoninstead of therex_configdatabase table. This decouples addon state from the database, simplifying deployments and paving the way for deeper Composer integration.Changes
AddonManager::getAddonConfig()/getAddonOrder()reading fromaddons.jsonAddonManager::saveAddonsData()with optionalconfig/orderparamsAddonManager::generatePackageOrder()togenerateAddonOrder()Core::getPackageConfig()/Core::getPackageOrder()(moved toAddonManager)$generatePackageOrderpropertyThe on-disk shape is
{config, order}:configis persisted addon state (all registered addons, alphabetical),orderis the dependency-sorted boot order of the available addons (a derived cache, intentionally kept separate fromconfig).Breaking changes
Core::getPackageConfig()andCore::getPackageOrder()have been moved toAddonManager::getAddonConfig()andAddonManager::getAddonOrder(). Rector rules are included for the rename.