refactor!: remove package.yml#6533
Merged
Merged
Conversation
…fig property The default_config setting was the last documented value in package.yml. Addons now declare their config defaults via a public protected(set) $defaultConfig property (overridable in subclasses), mirroring how $load is handled.
package.yml is no longer read at all. The property getters/setters (get/has/set/removeProperty) remain as an in-memory store (e.g. successmsg set from within the install() hook), but loadProperties(), the package.yml properties cache, the install-time package.yml parse check and the package.yml JSON schema are gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
package.ymlfrom addons entirely. It was already reduced to a single meaningful value (default_config); this finishes the job.Two commits:
default_config→Addon::$defaultConfig— the last documentedpackage.ymlvalue now lives as an overridablepublic protected(set) array $defaultConfigproperty on the addon class, mirroring how$loadis handled.package.ymlloading and its caching —loadProperties(), thepackages.cacheproperties cache, the install-timepackage.ymlparse check and thepackage.ymlJSON schema are gone.The in-memory property store (
get/has/set/removeProperty) stays —successmsgis still set from within theinstall()hook and read afterwards.Breaking changes
package.yml. Config defaults move to the$defaultConfigproperty.Addon::FILE_PACKAGE,Addon::loadProperties()and thepackage.ymlJSON schema are removed.