fix: persist errormail throttle state via setConfig instead of getConfig#6534
Merged
Conversation
The errormail throttling stored the last error hash and send time with getConfig instead of setConfig, so the values were never persisted and the time-/content-based throttling never took effect. Introduced in #5894 when the phpmailer addon was dissolved into core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
Mailer::errorMail()wurden der Hash der letzten Fehler und der Sende-Zeitstempel mitgetConfigstattsetConfiggespeichert:Dadurch wurden die Werte nie persistiert – das zweite Argument wird von
getConfiglediglich als Default-Wert interpretiert und verworfen. Die kombinierte Zeit-/Inhalts-Drosselung beim Versand von Fehler-Mails lief damit faktisch ins Leere.Ursache
Eingeschleppt in #5894, als das PhpMailer-Addon in den Core aufgelöst wurde. Im Original-Addon war es noch korrekt
$addon->setConfig(...); beim Umbau auf dierex::-Config-API istsetzugetverrutscht.Fix
Beide Aufrufe auf
setConfigkorrigiert.