Skip to content

Realtime Parameters based on Blob Type and added modelVersion to response builders for improved token logging - #191

Merged
Sandeep-BA merged 2 commits into
redbus-labs:mainfrom
rohanvij05:main
Aug 12, 2026
Merged

Realtime Parameters based on Blob Type and added modelVersion to response builders for improved token logging#191
Sandeep-BA merged 2 commits into
redbus-labs:mainfrom
rohanvij05:main

Conversation

@rohanvij05

Copy link
Copy Markdown

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed java test results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • My pull request contains a single commit.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

Rohan Vijay added 2 commits August 11, 2026 14:14
…ob type

- Introduced `buildRealtimeInputParameters` method in `GeminiLlmConnection` to determine whether to use audio or video fields based on the blob's MIME type.
- Updated `sendRealtime` method to utilize the new parameter building method.
- Added unit tests to verify correct behavior for audio and video blobs in `GeminiLlmConnectionTest`.
…logging

- Enhanced response builders in `OllamaBaseLM` to include `modelVersion`, allowing downstream token logging to resolve the model name instead of defaulting to "unknown".
- Updated multiple response building methods to ensure consistent model versioning across different response types.
@Sandeep-BA
Sandeep-BA merged commit 4df72ab into redbus-labs:main Aug 12, 2026
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants