add option to do server side apply#113
Open
jwang99 wants to merge 1 commit intoreddit:mainfrom
Open
Conversation
This was referenced May 6, 2026
william-richard
left a comment
william-richard
left a comment
There was a problem hiding this comment.
LGTM, but I don't feel quite qualified enough to approve
harveyxia
approved these changes
May 7, 2026
Collaborator
harveyxia
left a comment
harveyxia
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding this! We should test e2e in a staging (or other high fidelity) environment before cutting a release
| for _, managedFields := range current.GetManagedFields() { | ||
| // we're doing a client-side apply, so we assume we own all fields even if the manager is not our own. | ||
| // in other words, no need to ensure that managedFields.Manager == a.managerName | ||
| // TODO: we should explore using server-side apply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Adding an option to do server-side apply, in addition to merge-patch (default) and Update. This is to enable the achilles-flink-controller to fully manage its own fields without overwriting fields that are managed by another controller, the flink kubernetes operator.
Jira
🧪 Testing Steps / Validation
Added unit tests
✅ Checks