chore: add tests workflow, fix linting

.gitattributes

@@ -1,2 +1,2 @@
 *.yml linguist-detectable
-*.yaml linguist-detectable
+*.yaml linguist-detectable

.github/pull_request_template.md

@@ -0,0 +1,19 @@
+# Description
+
+## Type of Change
+
+- [ ] feat: A new feature
+- [ ] fix: A bug fix
+- [ ] docs: Documentation changes
+- [ ] style: Formatting, missing semi colons, etc; no code change
+- [ ] refactor: Refactoring production code
+- [ ] test: Adding missing tests, refactoring tests; no production code change
+- [ ] chore: Updating configs, etc; no production code change
+
+## Pull Request Title
+
+> **Note:** Please ensure your PR title follows [Conventional Commits](https://www.conventionalcommits.org/en/v2.0.0/).
+> Example: `feat: add role`
+
+- [ ] I have formatted my PR title correctly.
+- [ ] I have added `[skip ci]` to the title (Maintainers only, if no release is needed).

.pre-commit-config.yaml

@@ -5,20 +5,20 @@ default_install_hook_types:
 
 repos:
 
-  - repo: https://github.com/compilerla/conventional-pre-commit
-    rev: v4.3.0
-    hooks:
-      - id: conventional-pre-commit
-        stages: [commit-msg]
-        args: [--verbose]
+  # - repo: https://github.com/compilerla/conventional-pre-commit
+  #   rev: v4.3.0
+  #   hooks:
+  #     - id: conventional-pre-commit
+  #       stages: [commit-msg]
+  #       args: [--verbose]
 
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v6.0.0
     hooks:
       - id: check-merge-conflict
       - id: check-symlinks
       - id: debug-statements
-      # - id: end-of-file-fixer
+      - id: end-of-file-fixer
       - id: no-commit-to-branch
         args: [--branch, main]
       - id: trailing-whitespace

CODE_OF_CONDUCT.md

@@ -1,3 +1,4 @@
 # Community Code of Conduct
 
-Please see the official [Ansible Community Code of Conduct](https://docs.ansible.com/ansible/latest/community/code_of_conduct.html).
+Please see the official
+[Ansible Community Code of Conduct](https://docs.ansible.com/ansible/latest/community/code_of_conduct.html).

CONTRIBUTING.md

@@ -1,12 +1,12 @@
 # Welcome to the Ansible for OpenShift Virtualization Migration collection!
 
-Please check our [Contributor's Guide](https://github.com/redhat-cop/openshift-virtualization-migration-documentation/-/blob/main/CONTRIBUTING.md).
+Please check our [Contributor's Guide](https://github.com/redhat-cop/openshift-virtualization-migration-documentation/blob/main/CONTRIBUTING.md).
 
 The [documentation repository](https://github.com/redhat-cop/openshift-virtualization-migration-documentation) contains information on how to get started, links to other resources, deployment guides and more.
 
 ## Using Red Hat Developer Sandbox
 
-NOTE: As this repository is currently not public you will need to create a personal access token and add that to your Developer Sandbox profile. Please perform the steps in the contribution guide [Using Red Hat Developer Sandbox](https://github.com/redhat-cop/openshift-virtualization-migration-documentation/-/blob/main/CONTRIBUTING.md#contribute-using-red-hat-developer-sandbox) section.
+NOTE: As this repository is currently not public you will need to create a personal access token and add that to your Developer Sandbox profile. Please perform the steps in the contribution guide [Using Red Hat Developer Sandbox](https://github.com/redhat-cop/openshift-virtualization-migration-documentation/blob/main/CONTRIBUTING.md#contribute-using-red-hat-developer-sandbox) section.
 
 Click the link below to launch your IDE hosted in the Developer Sandbox:
 

LICENSE

@@ -645,7 +645,7 @@ the "copyright" line and a pointer to where the full notice is found.
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+    along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 Also add information on how to contact you by electronic and paper mail.
 
@@ -664,11 +664,11 @@ might be different; for a GUI interface, you would use an "about box".
   You should also get your employer (if you work as a programmer) or school,
 if any, to sign a "copyright disclaimer" for the program, if necessary.
 For more information on this, and how to apply and follow the GNU GPL, see
-<http://www.gnu.org/licenses/>.
+<https://www.gnu.org/licenses/>.
 
   The GNU General Public License does not permit incorporating your program
 into proprietary programs.  If your program is a subroutine library, you
 may consider it more useful to permit linking proprietary applications with
 the library.  If this is what you want to do, use the GNU Lesser General
 Public License instead of this License.  But first, please read
-<http://www.gnu.org/philosophy/why-not-lgpl.html>.
+<https://www.gnu.org/licenses/why-not-lgpl.html>.

galaxy.yml

@@ -42,19 +42,26 @@ dependencies:
 repository: >-
   https://github.com/redhat-cop/openshift_virtualization_migration
 
-manifest:
-  directives:
-    - include meta/*.yml README.md inventory.yml CHANGELOG.md CODEOWNERS LICENSE MANIFEST.json FILES.json
-    - include requirements-dev.yml
-    - recursive-include docs **.rst **.yml **.yaml **.json **.j2 **.txt
-    - recursive-include roles **.yml **.yaml **.json **.j2 **.md
-    - recursive-include playbooks **.yml **.yaml **.json
-    - recursive-include changelogs **.yml **.yaml
-    - recursive-include plugins *
-    - recursive-include tests **.yml **.yaml **.py
-    - exclude infra-openshift_virtualization_migration-*.tar.gz
-    - recursive-exclude tests/output **
-    - global-exclude /.* /__pycache__
-    - include .ansible-lint .yamllint tox* pyproject.toml config.yml
-  omit_default_directives: true
+build_ignore:
+  - .ansible
+  - .ansible-lint
+  - .git
+  - .gitattributes
+  - .github
+  - .gitignore
+  - .isort.cfg
+  - .markdownlint-cli2.yaml
+  - .pre-commit-config.yaml
+  - .prettierignore
+  - .tox
+  - .yamllint
+  - collection-build.log
+  - pyproject.toml
+  - requirements-dev.txt
+  - requirements-ci.txt
+  - scripts
+  - test-requirements.txt
+  - tox-ansible.ini
+  - tox.ini
+  - "*.sarif"
 ...

roles/aap_deploy/README.md

@@ -214,4 +214,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/aap_deploy/tests/inventory

@@ -1,2 +1 @@
 localhost
-

roles/aap_machine_credentials/README.md

@@ -213,4 +213,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/aap_machine_credentials/tests/inventory

@@ -1,2 +1 @@
 localhost
-

roles/aap_seed/README.md

@@ -1358,4 +1358,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/aap_seed/templates/git_credential.yml.j2

@@ -13,4 +13,4 @@ inputs:
 {% endif %}
 {% if aap_seed_git_ssh_key_passphrase %}
   ssh_key_unlock: "{{ aap_seed_git_ssh_key_passphrase }}"
-{% endif %}
+{% endif %}

roles/aap_seed/templates/migration_factory_configuration_workflow.yml.j2

@@ -14,4 +14,4 @@ simplified_workflow_nodes:
       - Target Configuration
   - all_parents_must_converge: false
     identifier: Target Configuration
-    unified_job_template: Configure OpenShift Virtualization Migration - Configure Migration Targets
+    unified_job_template: Configure OpenShift Virtualization Migration - Configure Migration Targets

roles/aap_seed/templates/mtv_all_targets_workflow.yml.j2

@@ -11,4 +11,4 @@ simplified_workflow_nodes:
   - all_parents_must_converge: false
     identifier: {{ workflow }}
     unified_job_template: {{ workflow }}
-{% endfor %}
+{% endfor %}

roles/aap_seed/templates/mtv_workflow.yml.j2

@@ -11,4 +11,4 @@ simplified_workflow_nodes:
   - all_parents_must_converge: false
     identifier: {{ workflow }}
     unified_job_template: {{ workflow }}
-{% endfor %}
+{% endfor %}

roles/aap_seed/templates/openshift_virtualization_migration_cac.yml.j2

@@ -11,4 +11,4 @@
    aap_inventory: "{{ aap_seed_aap_inventory }}"
    aap_job_template_extra_vars: "{{ aap_seed_aap_job_template_extra_vars | to_yaml }}"
    aap_version: "{{ aap_seed_aap_version }}"
-   migration_targets: '{{ _aap_seed_cluster_migration_targets | to_json }}'
+   migration_targets: '{{ _aap_seed_cluster_migration_targets | to_json }}'

roles/aap_seed/templates/operator_job_template.yml.j2

@@ -8,4 +8,4 @@ playbook: playbooks/operator_management.yml
 inventory: "{{ aap_seed_aap_inventory }}"
 execution_environment: "{{ aap_seed_aap_execution_environment }}"
 credentials:
-    - Kubeconfig - {{ _mf_host }}
+    - Kubeconfig - {{ _mf_host }}

roles/aap_seed/templates/operator_workflow.yml.j2

@@ -11,4 +11,4 @@ simplified_workflow_nodes:
   - all_parents_must_converge: false
     identifier: Configure OpenShift Virtualization Migration Operators - {{ _mf_host }}
     unified_job_template: OpenShift Virtualization Migration - Configure Operators - {{ _mf_host }}
-{% endfor %}
+{% endfor %}

roles/aap_seed/templates/ovirt/migrate_job_template.j2

@@ -9,4 +9,4 @@ playbook: playbooks/mtv_migrate.yml
 inventory: "{{ aap_seed_aap_inventory }}"
 execution_environment: "{{ aap_seed_aap_execution_environment }}"
 credentials:
-    - Kubeconfig - {{ _mf_host }}
+    - Kubeconfig - {{ _mf_host }}

roles/aap_seed/templates/ovirt/mtv_mapping_job_template.yaml.j2

@@ -11,4 +11,4 @@ execution_environment: "{{ aap_seed_aap_execution_environment }}"
 credentials:
   - {{ _kubeconfig_credential }}
   - {{ _target_credential }}
-  - {{ _mf_cac_credential }}
+  - {{ _mf_cac_credential }}

roles/aap_seed/templates/vmware/migrate_job_template.j2

@@ -9,4 +9,4 @@ playbook: playbooks/mtv_migrate.yml
 inventory: "{{ aap_seed_aap_inventory }}"
 execution_environment: "{{ aap_seed_aap_execution_environment }}"
 credentials:
-    - Kubeconfig - {{ _mf_host }}
+    - Kubeconfig - {{ _mf_host }}

roles/aap_seed/templates/vmware/mtv_vddk_job_template.yaml.j2

@@ -12,4 +12,4 @@ credentials:
   - {{ _kubeconfig_credential }}
   - {{ _target_credential }}
   - {{ _mf_cac_credential }}
-{% endif %}
+{% endif %}

roles/bootstrap/README.md

@@ -256,4 +256,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/create_mf_aap_token/README.md

@@ -104,4 +104,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/mtv_management/README.md

@@ -589,4 +589,4 @@ GPL-3.0-only
 
 * **EL**: ['all']
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/mtv_management/templates/ovirt_provider_skeleton.yml.j2

@@ -8,4 +8,4 @@ spec:
     name: "{{ mtv_management_ovirt_provider_secret_name }}"
     namespace: "{{ mtv_management_ovirt_provider_secret_namespace }}"
   type: ovirt
-  url: "{{ mtv_management_mtv_ovirt_url }}"
+  url: "{{ mtv_management_mtv_ovirt_url }}"

roles/mtv_management/tests/inventory

@@ -1,2 +1 @@
 localhost
-

roles/mtv_migrate/README.md

@@ -587,4 +587,4 @@ GPL-3.0-only
 
 * **EL**: ['all']
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/mtv_migrate/tests/inventory

@@ -1,2 +1 @@
 localhost
-

roles/network_mgmt/README.md

@@ -360,4 +360,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/network_mgmt/templates/linux-bridge/nad.yaml.j2

@@ -37,4 +37,3 @@ spec:
      "vlan": {{ portgroup.vlan.vlan_id | int }}
 {% endif %}
      }
-

roles/network_mgmt/templates/linux-bridge/nncp.yaml.j2

@@ -53,4 +53,3 @@ spec:
   maxUnavailable: {{ network_mgmt_nncp_max_unavailable }}
   nodeSelector:
     {{ network_mgmt_nncp_nodeselector }}
-

roles/network_mgmt/templates/manual-lb/nad.yaml.j2

@@ -47,4 +47,3 @@ spec:
      "netAttachDefName": "{{ nad.namespace | default(network_mgmt_nad_namespace) }}/{{ nad.name }}"
     }
 {% endif %}
-

roles/network_mgmt/templates/manual-lb/nncp.yaml.j2

@@ -46,4 +46,3 @@ spec:
   maxUnavailable: {{ network_mgmt_nncp_max_unavailable }}
   nodeSelector:
     {{ network_mgmt_nncp_nodeselector }}
-

roles/network_mgmt/templates/ovs-bridge/nad.yaml.j2

@@ -17,4 +17,4 @@ spec:
      "netAttachDefName": "{{ network_mgmt_nad_namespace }}/{{ portgroup.name | infra.openshift_virtualization_migration.rfc1123(network_mgmt_nad_name_prefix, "^[\d]+") }}",
      "mtu": {{ (network_mgmt_switches_to_migrate | selectattr('name','equalto', portgroup.switch) | first).mtu }},
      "vlanID": {{ portgroup.vlan.vlan_id | int }}
-     }
+     }

roles/network_mgmt/templates/ovs-bridge/nncp.yaml.j2

@@ -65,4 +65,3 @@ spec:
   maxUnavailable: {{ network_mgmt_nncp_max_unavailable }}
   nodeSelector:
     {{ network_mgmt_nncp_nodeselector }}
-

roles/network_mgmt/tests/inventory

@@ -1,2 +1 @@
 localhost
-

roles/operator_management/README.md

@@ -677,4 +677,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/operator_management/tests/inventory

@@ -1,2 +1 @@
 localhost
-

roles/validate_migration/README.md

@@ -284,4 +284,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/validate_migration/tests/inventory

@@ -1,2 +1 @@
 localhost
-

roles/vm_backup_restore/README.md

@@ -237,4 +237,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/vm_backup_restore/tests/inventory

@@ -1,2 +1 @@
 localhost
-

roles/vm_collect/README.md

@@ -121,4 +121,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/vm_collect/tests/inventory

@@ -1,2 +1 @@
 localhost
-

roles/vm_hot_plug/README.md

@@ -208,4 +208,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/vm_hot_plug/templates/compute_patch.yml.j2

@@ -16,4 +16,3 @@
   value: {{ vm_hot_plug_compute['memory'] }}
 {% endif %}
 {% endif %}
-

roles/vm_hot_plug/templates/storage_datavolume_request.yml.j2

@@ -9,4 +9,4 @@ volumeSource:
     name: {{ vm_hot_plug_storage_instance.name }}
 {% else %}
 name: {{ vm_hot_plug_storage_instance.name }}
-{% endif %}
+{% endif %}

roles/vm_hot_plug/tests/inventory

@@ -1,2 +1 @@
 localhost
-

roles/vm_lifecycle/README.md

@@ -240,4 +240,4 @@ GPL-3.0-only
 
 No platforms specified.
 
-<!-- DOCSIBLE END -->
+<!-- DOCSIBLE END -->

roles/vm_lifecycle/tests/inventory

@@ -1,2 +1 @@
 localhost
-