Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
9 changes: 9 additions & 0 deletions PROJECT
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,13 @@ resources:
kind: ChunksGenerator
path: github.com/redhat-data-and-ai/unstructured-data-controller/api/v1alpha1
version: v1alpha1
- api:
crdVersion: v1
namespaced: true
controller: true
domain: dataverse.redhat.com
group: operator
kind: GoogleDriveInformer
path: github.com/redhat-data-and-ai/unstructured-data-controller/api/v1alpha1
version: v1alpha1
version: "3"
112 changes: 112 additions & 0 deletions api/v1alpha1/googledriveinformer_types.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
/*
Copyright 2026.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package v1alpha1

import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

const (
GoogleDriveInformerCondition = "GoogleDriveInformerReady"
)

type Folder struct {
ID string `json:"id"`
}

// GoogleDriveInformerSpec defines the desired state of GoogleDriveInformer.
type GoogleDriveInformerSpec struct {
DataProduct string `json:"dataProduct"`
Folders []Folder `json:"folders"`
Secret string `json:"secret"`
}

// GoogleDriveInformerStatus defines the observed state of GoogleDriveInformer.
type GoogleDriveInformerStatus struct {
LastAppliedGeneration int64 `json:"lastAppliedGeneration,omitempty"`
PageToken string `json:"pageToken,omitempty"`
Conditions []metav1.Condition `json:"conditions,omitempty"`
}

// +kubebuilder:object:root=true
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.conditions[?(@.type=="GoogleDriveInformerReady")].status`
// +kubebuilder:printcolumn:name="Message",type=string,JSONPath=`.status.conditions[?(@.type=="GoogleDriveInformerReady")].message`

// GoogleDriveInformer is the Schema for the googledriveinformers API.
type GoogleDriveInformer struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`

Spec GoogleDriveInformerSpec `json:"spec,omitempty"`
Status GoogleDriveInformerStatus `json:"status,omitempty"`
}

// +kubebuilder:object:root=true

// GoogleDriveInformerList contains a list of GoogleDriveInformer.
type GoogleDriveInformerList struct {
metav1.TypeMeta `json:",inline"`
metav1.ListMeta `json:"metadata,omitempty"`
Items []GoogleDriveInformer `json:"items"`
}

func (g *GoogleDriveInformer) SetWaiting() {
condition := metav1.Condition{
Type: GoogleDriveInformerCondition,
LastTransitionTime: metav1.Now(),
Status: metav1.ConditionUnknown,
Message: "GoogleDriveInformer is getting reconciled",
Reason: "Waiting",
}
for i, currentCondition := range g.Status.Conditions {
if currentCondition.Type == condition.Type {
g.Status.Conditions[i] = condition
return
}
}
g.Status.Conditions = append(g.Status.Conditions, condition)
}

func (g *GoogleDriveInformer) UpdateStatus(message string, err error) {
condition := metav1.Condition{
Type: GoogleDriveInformerCondition,
LastTransitionTime: metav1.Now(),
}
if err == nil {
condition.Status = metav1.ConditionTrue
condition.Message = message
condition.Reason = SuccessfullyReconciled
g.Status.LastAppliedGeneration = g.Generation
} else {
condition.Status = metav1.ConditionFalse
condition.Message = message + ", error: " + err.Error()
condition.Reason = ReconcileFailed
}

for i, currentCondition := range g.Status.Conditions {
if currentCondition.Type == condition.Type {
g.Status.Conditions[i] = condition
return
}
}
g.Status.Conditions = append(g.Status.Conditions, condition)
}
Comment on lines +85 to +108
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic to find and update a status condition is duplicated in SetWaiting and UpdateStatus. You can simplify this and remove the duplication by using meta.SetStatusCondition from the k8s.io/apimachinery/pkg/api/meta package. You will need to add "fmt" and "k8s.io/apimachinery/pkg/api/meta" to your imports.

Additionally, it's more idiomatic to use fmt.Sprintf for formatting error messages.

func (g *GoogleDriveInformer) UpdateStatus(message string, err error) {
	condition := metav1.Condition{
		Type:               GoogleDriveInformerCondition,
		LastTransitionTime: metav1.Now(),
	}
	if err == nil {
		condition.Status = metav1.ConditionTrue
		condition.Message = message
		condition.Reason = SuccessfullyReconciled
		g.Status.LastAppliedGeneration = g.Generation
	} else {
		condition.Status = metav1.ConditionFalse
		condition.Message = fmt.Sprintf("%s, error: %v", message, err)
		condition.Reason = ReconcileFailed
	}

	meta.SetStatusCondition(&g.Status.Conditions, condition)
}


func init() {
SchemeBuilder.Register(&GoogleDriveInformer{}, &GoogleDriveInformerList{})
}
116 changes: 116 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,13 @@ func main() {
setupLog.Error(err, "unable to create controller", "controller", "ChunksGenerator")
os.Exit(1)
}
if err := (&controller.GoogleDriveInformerReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
}).SetupWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "GoogleDriveInformer")
os.Exit(1)
}
// +kubebuilder:scaffold:builder

if metricsCertWatcher != nil {
Expand Down
Loading