Skip to content

fix: AppProjects's description based filter#250

Open
aali309 wants to merge 1 commit into
redhat-developer:mainfrom
aali309:GITOPS-10130
Open

fix: AppProjects's description based filter#250
aali309 wants to merge 1 commit into
redhat-developer:mainfrom
aali309:GITOPS-10130

Conversation

@aali309

@aali309 aali309 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Signed-off-by: Atif Ali <atali@redhat.com>
@openshift-ci openshift-ci Bot requested review from keithchong and wtam2018 June 25, 2026 21:30
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 2fbe2f42-d477-4600-a38a-0ccb248892ab

📥 Commits

Reviewing files that changed from the base of the PR and between 01e9db1 and 3e17b26.

📒 Files selected for processing (1)
  • src/gitops/components/project/ProjectList.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved project list filtering behavior for more consistent results.
    • The “Applications” filter now appears only when application data is available, preventing misleading filter options during loading or when data is unavailable.
    • Made row filtering more reliable across project details like descriptions, applications, type, source repositories, and destinations.

Walkthrough

ProjectList.tsx now computes project row filter IDs through shared helpers and builds the filter list with a reusable RowFilter factory. The Applications filter still skips evaluation when applications data is unavailable or not loaded.

Changes

Project list row filter refactor

Layer / File(s) Summary
Shared row-filter helpers
src/gitops/components/project/ProjectList.tsx
Internal helpers compute filter IDs for description, applications, project type, source repos, and destinations, and a shared createProjectRowFilter builder centralizes predicate logic.
Filters use shared factory
src/gitops/components/project/ProjectList.tsx
getFilters switches the five project filters to createProjectRowFilter calls and keeps the Applications filter skip condition when applications data is unavailable or not loaded.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and directly reflects the description-based filter change in this PR.
Description check ✅ Passed The description references the linked Jira issue, which is related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.85%. Comparing base (01e9db1) to head (3e17b26).

Files with missing lines Patch % Lines
src/gitops/components/project/ProjectList.tsx 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   11.92%   11.85%   -0.07%     
==========================================
  Files         154      154              
  Lines        6272     6316      +44     
  Branches     2028     2161     +133     
==========================================
+ Hits          748      749       +1     
- Misses       5524     5567      +43     
Flag Coverage Δ
unit-tests 11.85% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants