WIP: Repository refactoring#47
Conversation
|
@sabre1041 Is the intent to move away from separating charts between |
|
@sabre1041 Do you want to also use chart-releaser to release charts to the branch created in #46, or will that be handled in a different PR? |
|
@deweya To address your comments:
|
.github/workflows/pr.yml
Outdated
| - name: Fetch history | ||
| run: git fetch --prune --unshallow |
There was a problem hiding this comment.
is this step really needed? And should not we the steps mentioned here: https://github.com/helm/chart-testing-action#example-workflow ?
.github/workflows/pr.yml
Outdated
| uses: helm/chart-testing-action@v2.0.1 | ||
|
|
||
| - name: Run chart-testing (lint) | ||
| run: ct lint --all |
There was a problem hiding this comment.
should not we lint only changed charts?
There was a problem hiding this comment.
I tend to prefer linting all charts regardless as it is not a lengthy process. For integration testing if we started to enable that aspect, would only target changed charts
There was a problem hiding this comment.
Hm, but updating chart_schema.yaml might make linting fails on charts that are not a part of PR. Would that be ok?
There was a problem hiding this comment.
Yeah it's something to consider. I use just ct lint since only changed charts will be linted. You don't really need to lint unchanged charts but I get doing it to be safe.
I think it's best to do just ct lint for the point @pedjak makes. I can see a quick change turning into a large PR with --all if we need to update chart_schema.yaml in the future. If we make a change to chart_schema.yaml with just ct lint, chart maintainers will just need to update their Chart.yaml file in their next update.
| - name: IBM | ||
| email: contsto2@in.ibm.com | ||
| #kubeVersion: '>=1.10.1' | ||
| # kubeVersion: '>=1.10.1' |
There was a problem hiding this comment.
This change was needed to allow chart-testing to pass
3 participants
Refactoring of master branch
chartsdirectoryDO NOT MERGE UNTIL GitHub Pages refactoring as part of #46 is completed and validated!