fix(#3549): add focus-visible indicators to Select menu#3561
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#3549): add focus-visible indicators to Select menu#3561fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add visible focus ring styles to the "top N" Select menu in adoption insights. The select trigger and dropdown menu items now show a 2px primary-colored outline on :focus-visible, restoring keyboard accessibility (WCAG 2.4.7 Focus Visible). The existing :focus style that sets backgroundColor to transparent is preserved, and a new :focus-visible rule adds the outline so keyboard-only users see a clear focus indicator without affecting mouse interactions. Closes #3549
fullsend-ai-coder
Bot
requested review from
a team,
Eswaraiahsapram,
karthikjeeyar and
rohitkrai03
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3561 +/- ##
=======================================
Coverage 53.82% 53.82%
=======================================
Files 2277 2277
Lines 87047 87049 +2
Branches 24387 24387
=======================================
+ Hits 46850 46852 +2
+ Misses 38660 38659 -1
- Partials 1537 1538 +1
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add visible focus ring styles to the "top N" Select menu in adoption insights. The select trigger and dropdown menu items now show a 2px primary-colored outline on :focus-visible, restoring keyboard accessibility (WCAG 2.4.7 Focus Visible).
The existing :focus style that sets backgroundColor to transparent is preserved, and a new :focus-visible rule adds the outline so keyboard-only users see a clear focus indicator without affecting mouse interactions.
Closes #3549
Post-script verification
agent/3549-add-focus-indicators)b57a430ea0c48b4dff885dc812072d5eccb6e0a2..HEAD)