fix(adoption-insights): enable keyboard navigation in header date range dropdown#3564
Draft
its-mitesh-kumar wants to merge 1 commit into
Conversation
…ge dropdown Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
its-mitesh-kumar
requested review from
a team,
Eswaraiahsapram,
karthikjeeyar and
rohitkrai03
as code owners
Changed Packages
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3564 +/- ##
=======================================
Coverage 53.63% 53.63%
=======================================
Files 2260 2260
Lines 85976 85976
Branches 24203 24203
=======================================
Hits 46117 46117
Misses 38314 38314
Partials 1545 1545
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix keyboard navigation in the Adoption Insights header date range dropdown. The MUI Select component had
autoFocusItem: falseset in itsMenuListProps, which prevented arrow keys from navigating menu items when the dropdown was opened. Users had to press Tab first before arrow keys would work, which is not intuitive for keyboard users.Removing
autoFocusItem: falserestores MUI's default behavior where focus is automatically placed on the selected menu item when the dropdown opens, allowing immediate arrow key navigation.Fixed
✔️ Checklist
Made with Cursor