test(orchestrator): add frontend hook and status coverage#3578
Open
rostalan wants to merge 2 commits into
Open
test(orchestrator): add frontend hook and status coverage#3578rostalan wants to merge 2 commits into
rostalan wants to merge 2 commits into
Conversation
Add targeted frontend tests for orchestrator hooks and status components so config and status regressions are caught earlier. Harden the status indicator fallback for unknown states so the covered behavior matches runtime behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Changed Packages
|
Use real orchestrator basic permissions in the permission-array hook test so the fixture matches the hook contract, and add the required changeset for the plugin package. Co-authored-by: Cursor <cursoragent@cursor.com>
|
rostalan
requested review from
a team,
christoph-jerolimov,
karthikjeeyar,
lholmquist and
lokanandaprabhu
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3578 +/- ##
==========================================
+ Coverage 54.19% 54.30% +0.11%
==========================================
Files 2303 2303
Lines 88305 88340 +35
Branches 24590 24623 +33
==========================================
+ Hits 47858 47977 +119
+ Misses 40238 40151 -87
- Partials 209 212 +3
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Author
|
/fs review |
Author
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 2:15 PM UTC · Completed 2:25 PM UTC |
ReviewFindingsLow
Labels: PR is primarily adding unit test coverage for existing hooks and components. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add targeted frontend unit tests for orchestrator frontend plugin to increase coverage and catch issues earlier.
Harden the status indicator fallback for unknown states so the covered behavior matches runtime behavior.
Hey, I just made a Pull Request!
✔️ Checklist