fix(#3579): add missing a11y assertion to runAccessibilityTests#3581
fix(#3579): add missing a11y assertion to runAccessibilityTests#3581fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
=======================================
Coverage 54.22% 54.22%
=======================================
Files 2307 2307
Lines 88341 88341
Branches 24595 24594 -1
=======================================
Hits 47907 47907
Misses 40166 40166
Partials 268 268
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
/fs-fix There are some a11y issue now in the code base. Here are some errors from playwright. Try to fix these issues without changing everything. Keep focused on the specific components. |
|
🤖 Fix · ❌ Terminated · Started 4:59 PM UTC · Ended 6:33 PM UTC |
The runAccessibilityTests helper in the bulk-import e2e tests collected accessibility scan results and attached them to the test info, but never asserted that violations were empty. This meant tests would silently pass even if accessibility violations were present. Add expect(accessibilityScanResults.violations).toEqual([]) to match the pattern used in other workspaces (global-header, lightspeed, extensions, etc.). Closes #3579
7d9188a to
29e74a7
Compare
|
|
🤖 Finished Fix · ❌ Failure · Started 4:59 PM UTC · Completed 6:33 PM UTC |



The runAccessibilityTests helper in the bulk-import e2e tests collected accessibility scan results and attached them to the test info, but never asserted that violations were empty. This meant tests would silently pass even if accessibility violations were present.
Add expect(accessibilityScanResults.violations).toEqual([]) to match the pattern used in other workspaces (global-header, lightspeed, extensions, etc.).
Closes #3579
Post-script verification
agent/3579-add-a11y-assertion)381f36a38dba5bb09e008fee36bfe722802f4c87..HEAD)