Skip to content

fix(#3579): add missing a11y assertion to runAccessibilityTests#3581

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3579-add-a11y-assertion
Open

fix(#3579): add missing a11y assertion to runAccessibilityTests#3581
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3579-add-a11y-assertion

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

The runAccessibilityTests helper in the bulk-import e2e tests collected accessibility scan results and attached them to the test info, but never asserted that violations were empty. This meant tests would silently pass even if accessibility violations were present.

Add expect(accessibilityScanResults.violations).toEqual([]) to match the pattern used in other workspaces (global-header, lightspeed, extensions, etc.).


Closes #3579

Post-script verification

  • Branch is not main/master (agent/3579-add-a11y-assertion)
  • Secret scan passed (gitleaks — 381f36a38dba5bb09e008fee36bfe722802f4c87..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.22%. Comparing base (709a720) to head (29e74a7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3581   +/-   ##
=======================================
  Coverage   54.22%   54.22%           
=======================================
  Files        2307     2307           
  Lines       88341    88341           
  Branches    24595    24594    -1     
=======================================
  Hits        47907    47907           
  Misses      40166    40166           
  Partials      268      268           
Flag Coverage Δ *Carryforward flag
adoption-insights 83.70% <ø> (ø) Carriedforward from 709a720
ai-integrations 67.95% <ø> (ø) Carriedforward from 709a720
app-defaults 69.79% <ø> (ø) Carriedforward from 709a720
augment 46.39% <ø> (ø) Carriedforward from 709a720
boost 74.96% <ø> (ø) Carriedforward from 709a720
bulk-import 72.46% <ø> (ø)
cost-management 14.10% <ø> (ø) Carriedforward from 709a720
dcm 61.79% <ø> (ø) Carriedforward from 709a720
extensions 61.53% <ø> (ø) Carriedforward from 709a720
global-floating-action-button 71.18% <ø> (ø) Carriedforward from 709a720
global-header 59.71% <ø> (ø) Carriedforward from 709a720
homepage 49.84% <ø> (ø) Carriedforward from 709a720
install-dynamic-plugins 56.77% <ø> (ø) Carriedforward from 709a720
konflux 91.49% <ø> (ø) Carriedforward from 709a720
lightspeed 68.55% <ø> (ø) Carriedforward from 709a720
mcp-integrations 85.46% <ø> (ø) Carriedforward from 709a720
orchestrator 38.30% <ø> (ø) Carriedforward from 709a720
quickstart 63.76% <ø> (ø) Carriedforward from 709a720
sandbox 79.56% <ø> (ø) Carriedforward from 709a720
scorecard 83.96% <ø> (ø) Carriedforward from 709a720
theme 61.26% <ø> (ø) Carriedforward from 709a720
translations 7.25% <ø> (ø) Carriedforward from 709a720
x2a 78.68% <ø> (ø) Carriedforward from 709a720

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709a720...29e74a7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christoph-jerolimov

Copy link
Copy Markdown
Member

/fs-fix

There are some a11y issue now in the code base. Here are some errors from playwright. Try to fix these issues without changing everything. Keep focused on the specific components.

Array [
  Object {
    "description": "Ensure an element's role supports its ARIA attributes",
    "help": "Elements must only use supported ARIA attributes",
    "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/aria-allowed-attr?application=playwright",
    "id": "aria-allowed-attr",
    "impact": "critical",
    "nodes": Array [
      Object {
        "all": Array [
          Object {
            "data": Array [
              "aria-checked=\"false\"",
            ],
            "id": "aria-allowed-attr",
            "impact": "critical",
            "message": "ARIA attribute is not allowed: aria-checked=\"false\"",
            "relatedNodes": Array [],
          },
        ],
        "any": Array [],
        "failureSummary": "Fix all of the following:
  ARIA attribute is not allowed: aria-checked=\"false\"",
          },
          Object {
            "data": null,
            "id": "presentational-role",
            "impact": "critical",
            "message": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\"",
            "relatedNodes": Array [],
          },
        ],
        "failureSummary": "Fix any of the following:
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element has no placeholder attribute
  Element's default semantics were not overridden with role=\"none\" or role=\"presentation\"",
        "html": "<input class=\"v5-PrivateSwitchBase-input css-1p3z7et-MuiSwitchBase-root\" type=\"checkbox\" data-indeterminate=\"false\">",
        "impact": "critical",
        "none": Array [],
        "target": Array [
          ".v5-MuiTableRow-hover:nth-child(5) > .v5-MuiTableCell-paddingNone.css-16991dt-MuiTableCell-root[scope=\"row\"] > .v5-MuiCheckbox-root.v5-MuiCheckbox-colorPrimary.v5-MuiCheckbox-sizeMedium > .v5-PrivateSwitchBase-input[type=\"checkbox\"][data-indeterminate=\"false\"]",
        ],
      },
    ],
    "tags": Array [
      "cat.forms",
      "wcag2a",
      "wcag412",
      "section508",
      "section508.22.n",
      "TTv5",
      "TT5.c",
      "EN-301-549",
      "EN-9.4.1.2",
      "ACT",
      "RGAAv4",
      "RGAA-11.1.1",
    ],
  },
]

@fullsend-ai-coder

fullsend-ai-coder Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Fix · ❌ Terminated · Started 4:59 PM UTC · Ended 6:33 PM UTC
Commit: 709a720 · View workflow run →

The runAccessibilityTests helper in the bulk-import e2e tests
collected accessibility scan results and attached them to the
test info, but never asserted that violations were empty. This
meant tests would silently pass even if accessibility violations
were present.

Add expect(accessibilityScanResults.violations).toEqual([]) to
match the pattern used in other workspaces (global-header,
lightspeed, extensions, etc.).

Closes #3579
@fullsend-ai-coder fullsend-ai-coder Bot force-pushed the agent/3579-add-a11y-assertion branch from 7d9188a to 29e74a7 Compare June 25, 2026 16:59
@sonarqubecloud

Copy link
Copy Markdown

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ❌ Failure · Started 4:59 PM UTC · Completed 6:33 PM UTC
Commit: 709a720 · View workflow run →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bulk import plugin: Add missing assertion (expect) to runAccessibilityTests

1 participant