feat(#3580): enable accessibility checks and fix a11y issues#3583
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
feat(#3580): enable accessibility checks and fix a11y issues#3583fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Remove the skipFailures option from runAccessibilityTests so that accessibility violations always cause test failures instead of being silently ignored. Fix WCAG 2.0/2.1 AA violations across the extensions plugin: - PluginCard: add role="link", tabIndex, keyboard handler, and aria-label to the clickable card for keyboard accessibility - PluginIcon: add role="img" and aria-label to CardMedia elements so screen readers announce plugin icons - RowActions: add aria-label to all IconButton components; replace nested IconButton+Switch with standalone Switch using inputProps aria-label to eliminate nested interactive elements - Badges: replace title attr with aria-label on BadgeChip; add role="img" and aria-label to BadgeTriangle; mark decorative SVG icons with aria-hidden - TabPanel: add id and aria-labelledby to the tabpanel element; replace keyless Fragment with keyed Box in inner map Update PluginIcon tests to verify the new aria-label attribute on both icon and fallback-icon states. Closes #3580
fullsend-ai-coder
Bot
requested review from
a team,
christoph-jerolimov and
karthikjeeyar
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the skipFailures option from runAccessibilityTests so that accessibility violations always cause test failures instead of being silently ignored.
Fix WCAG 2.0/2.1 AA violations across the extensions plugin:
aria-label to the clickable card for keyboard accessibility
so screen readers announce plugin icons
nested IconButton+Switch with standalone Switch using inputProps
aria-label to eliminate nested interactive elements
role="img" and aria-label to BadgeTriangle; mark decorative
SVG icons with aria-hidden
replace keyless Fragment with keyed Box in inner map
Update PluginIcon tests to verify the new aria-label attribute on both icon and fallback-icon states.
Closes #3580
Post-script verification
agent/3580-enable-a11y-checks)709a7203bb9a6c9cd2f939d6b89e22014e3d4fa9..HEAD)