fix(#3589): enable a11y assertions and fix violations#3592
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#3589): enable a11y assertions and fix violations#3592fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Remove the skipViolationsAssert option from runAccessibilityTests and its callers so that axe-core accessibility violations are always asserted in e2e tests. Fix the identified accessibility violations: - Replace nested IconButton inside ListItem[role="button"] with a non-interactive Box to eliminate the nested-interactive violation - Add aria-label to LinearProgress in QuickstartFooter for screen reader accessibility - Add progressBarAriaLabel translation key to all locale files (en, de, es, fr, it, ja) Update unit tests to find expand/collapse controls by the ListItem's aria-label pattern instead of the removed IconButton. Closes #3589
fullsend-ai-coder
Bot
requested review from
a team,
divyanshiGupta and
its-mitesh-kumar
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the skipViolationsAssert option from runAccessibilityTests and its callers so that axe-core accessibility violations are always asserted in e2e tests.
Fix the identified accessibility violations:
non-interactive Box to eliminate the nested-interactive violation
reader accessibility
(en, de, es, fr, it, ja)
Update unit tests to find expand/collapse controls by the ListItem's aria-label pattern instead of the removed IconButton.
Closes #3589
Post-script verification
agent/3589-enable-a11y-checks)bf40fcbfc158b35397d937a224171422a6e41819..HEAD)