fix(#3587): remove a11y violation filter and fix list violation#3595
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#3587): remove a11y violation filter and fix list violation#3595fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Remove the `getFilteredViolations` function and `NFS_IGNORED_VIOLATION_IDS` from the e2e accessibility test utility. The filter was suppressing the axe `list` rule violation in NFS mode instead of fixing the root cause. The `list` violation originated from the upstream `HomePageToolkit` component (`@backstage/plugin-home`) which renders `<Link>` elements as direct children of `<List>` (`<ul>`), violating WCAG list structure requirements. Replace `HomePageToolkit` and `ComponentAccordion` usage in `QuickAccessCardContent` with a local `QuickAccessToolkit` component that wraps each tool link in a proper `<ListItem>` (`<li>`) element. The `report-alpha.api.md` update is a key-ordering change produced by `build:api-reports` — no API surface was added or removed. Closes #3587
fullsend-ai-coder
Bot
requested review from
a team,
Eswaraiahsapram and
christoph-jerolimov
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
getFilteredViolationsfunction andNFS_IGNORED_VIOLATION_IDSfrom the e2e accessibility test utility. The filter was suppressing the axelistrule violation in NFS mode instead of fixing the root cause.The
listviolation originated from the upstreamHomePageToolkitcomponent (@backstage/plugin-home) which renders<Link>elements as direct children of<List>(<ul>), violating WCAG list structure requirements. ReplaceHomePageToolkitandComponentAccordionusage inQuickAccessCardContentwith a localQuickAccessToolkitcomponent that wraps each tool link in a proper<ListItem>(<li>) element.The
report-alpha.api.mdupdate is a key-ordering change produced bybuild:api-reports— no API surface was added or removed.Closes #3587
Post-script verification
agent/3587-remove-a11y-violation-filter)4866641df899e78f168c77d1266ed4c8bd249149..HEAD)