feat(#4285): wire ConnectorConfigReader runtimeEnabled to RuntimeConfigResolver - #4316
feat(#4285): wire ConnectorConfigReader runtimeEnabled to RuntimeConfigResolver#4316fullsend-ai-coder[bot] wants to merge 3 commits into
Conversation
…igResolver Inject RuntimeConfigResolver into ConnectorConfigReader so that the runtimeEnabled flag for each connector is resolved via the two-layer config model (YAML baseline + DB overrides) instead of YAML-only via ConfigApi. This enables admin panel toggles for connector runtime sync to take effect within the 30-second cache TTL. Changes: - ConnectorConfigReader: add resolver option, make listCandidates() async, replace getRuntimeEnabled() with resolveRuntimeEnabled() that calls resolver.resolve() for registered BoostConfigKey fields with YAML-only fallback - HealthStatusService: await the now-async listCandidates() - plugin.ts: pass runtimeConfigResolver to ConnectorConfigReader - Tests: update mocks for async listCandidates, add test cases for YAML-only default, DB override, startup-disabled exclusion, and resolver key verification - API reports: regenerated for public API surface change Closes #4285
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4316 +/- ##
==========================================
+ Coverage 61.23% 61.24% +0.01%
==========================================
Files 2507 2513 +6
Lines 100386 100513 +127
Branches 28131 28185 +54
==========================================
+ Hits 61468 61556 +88
- Misses 37104 37143 +39
Partials 1814 1814
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
/fs-fix changeset and all known issues so far (like CI) |
|
🤖 Finished Fix · ✅ Success · Started 6:51 AM UTC · Completed 7:12 AM UTC Commit: |
- Add changeset for boost-backend minor: ConnectorConfigReader now resolves runtimeEnabled via RuntimeConfigResolver (async listCandidates, required resolver option) - Revert frontend boost/report.api.md to main's version since this PR does not change frontend code; the stale reorderings caused CI api-report check failures on the merge commit Addresses review feedback on #4316
🔧 Fix agent — iteration 1 (human-triggered)Added missing changeset for boost-backend (minor) and fixed CI api-report failure by reverting the frontend report.api.md to main's version since this PR does not modify frontend code. Fixed (2):
Tests: passed Updated by fullsend fix agent |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 7:33 AM UTC · Completed 8:06 AM UTC Commit: |
ReviewFindingsMedium
Low
Labels: PR modifies boost workspace ingestion and config resolution code; changeset declares a feature-level change Previous runReviewFindingsMedium
Low
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
the
requires-manual-review
Warn on non-boolean RuntimeConfigResolver values, clarify unit tests, cover resolver-failure YAML fallback, and mark the changeset as BREAKING. Signed-off-by: Marek Libra <marek.libra@gmail.com>
|
I have sent fixes based on my review. |
|
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 9:56 AM UTC · Completed 10:11 AM UTC Commit: |
fullsend-ai-review
Bot
added
workspace/boost
1 participant
Inject RuntimeConfigResolver into ConnectorConfigReader so that the runtimeEnabled flag for each connector is resolved via the two-layer config model (YAML baseline + DB overrides) instead of YAML-only via ConfigApi. This enables admin panel toggles for connector runtime sync to take effect within the 30-second cache TTL.
Changes:
listCandidates() async, replace getRuntimeEnabled() with
resolveRuntimeEnabled() that calls resolver.resolve() for
registered BoostConfigKey fields with YAML-only fallback
for YAML-only default, DB override, startup-disabled exclusion,
and resolver key verification
Closes #4285
Post-script verification
agent/4285-wire-runtime-enabled)e6c850f7dd03d646d614fb0c74f80e7e4b9d0026..HEAD)