feat: add NFS migration and Backstage upgrade skills#45
Conversation
c19b406 to
ea55088
Compare
|
@rohitkrai03 I think this skill would be better served upstream rather than here. https://github.com/backstage/backstage/tree/master/docs/.well-known/skills |
dc03c6b to
5e4dcd1
Compare
@schultzp2020 This skill also has knowledge about RHDH specific extensions and blueprints that were converted from old dynamic plugin mount points to NFS APIs. It was created based on the idea that we would need to provide some kind of a guide to customers that they can use to learn about NFS migration and a skill that can help with that migration. I can create a generic one suited for upstream but I can see its already there - https://github.com/backstage/backstage/blob/master/docs/.well-known/skills/plugin-new-frontend-system-support/SKILL.md. |
Can you create a PR to update the generic one with the new findings you have here? |
@schultzp2020 You mean including RHDH specific references? |
No, just the Backstage specific ones. |
durandom
left a comment
There was a problem hiding this comment.
Review: NFS Migration & Backstage Upgrade Skills
High-quality skill content — the NFS migration guide (docs/nfs-migration-guide.md) is genuinely excellent. Real PR references, gotcha lists, before/after examples, RHDH-specific extensions (drawer, header, homepage). This is the kind of knowledge that's hard to find in one place.
What's good
- Comprehensive reference material — 12 reference files, 3 before/after examples, real migration PRs from rhdh-plugins. The mount-point mapping table alone saves hours of digging.
- Composable design —
backstage-upgradecan be called standalone or chained fromnfs-migration. The cross-skill references are clean. - Follows existing skill patterns — intake → routing → workflow → references structure matches other skills in the repo.
- Validated against a real plugin — the quay migration is a strong signal that the patterns work end-to-end.
Blocking
- Version bump goes backward — see inline comment on
pyproject.toml
Non-blocking suggestions
- No tests — the PR description claims "283 tests pass" but adds zero test files for either skill. Existing skills in this repo have structural tests under
tests/unit/. Since these are pure markdown skills with no scripts, this may be intentional — but worth clarifying. - NFS migration guide duplicates skill reference content —
docs/nfs-migration-guide.md(482 lines) overlaps significantly with the skill's reference files (api-changes.md, gotchas.md, migrate-page.md). This creates a maintenance burden — changes to one must be reflected in the other. Consider making the guide the authoritative human-readable source and having the skill reference files link to it (or vice versa), rather than duplicating content. - See inline comments for minor consistency issues.
- Bump version to 0.6.0 (rebase on main which is at 0.5.0) - Remove @ prefix from backstage-upgrade in routing table - Add dependency note for cross-skill version reference - Add cross-references between NFS guide and skill references Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5e4dcd1 to
94e076f
Compare
- Bump version to 0.6.0 (rebase on main which is at 0.5.0) - Remove @ prefix from backstage-upgrade in routing table - Add dependency note for cross-skill version reference - Add cross-references between NFS guide and skill references Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2e0788a to
5241d60
Compare
- Bump version to 0.6.0 (rebase on main which is at 0.5.0) - Remove @ prefix from backstage-upgrade in routing table - Add dependency note for cross-skill version reference - Add cross-references between NFS guide and skill references Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Bump version to 0.6.0 (rebase on main which is at 0.5.0) - Remove @ prefix from backstage-upgrade in routing table - Add dependency note for cross-skill version reference - Add cross-references between NFS guide and skill references Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fixes
Summary
@backstage/*dependencies usingbackstage-cli versions:bump, with RHDH version alignment, changelog-based breaking change review, and moved package migration. This skill is also used by the NFS migration skill.Test plan
pytest— 283 tests passruff check— clean@backstage-community/plugin-quayusing the skill —tsc,build, and all 79 tests pass🤖 Generated with Claude Code