This repository was archived by the owner on Mar 14, 2025. It is now read-only.
Added scenario to handle enable/disable of setup button. Also button text changed based on the scenario that either setup/update#156
Open
msivasubramaniaan wants to merge 2 commits intoredhat-developer:mainfrom
Conversation
…andled enable/disable of the button Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
|
Disabling the button when there's no change is nice, but if I don't realize that I've selected the current options it could be confusing why the button won't enable. IMHO either the button text needs to change as well, or replace the button with a label. Just something to indicate 'these are the current settings/configuration'. |
Collaborator
|
I'm dubious about this proposed change. The behavior is inconsistent between:
I don't want to disable the button if the models are identical to what's in config.json, as I regularly rerun the setup because specific settings, other than the model id (context length, maxTokens ...) can change between extension builds, so I need to apply those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps to handle the below scenarios, and it would be nice to have as a user perspective.
PFA