This repository was archived by the owner on Mar 14, 2025. It is now read-only.
Use 'stop' icon when Ollama is stopped#191
Open
fbricon wants to merge 1 commit intoredhat-developer:mainfrom
Open
Use 'stop' icon when Ollama is stopped#191fbricon wants to merge 1 commit intoredhat-developer:mainfrom
fbricon wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Collaborator
Author
|
@allanday is that acceptable for you? |
Personally, I'd leave the circle empty in this stopped state. The inverse of the stop icon is a play icon, rather than a check, so it's mixing metaphors, and it's deviating from the broader semantics of a check list. Plus the small size makes the square difficult to identify. |
Collaborator
Author
|
Sure I can do empty circle. Which colour then? blue/red/default ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157