Fix StackOverflow when selecting a schema for a YAML file that matches multiple schemas#1253
Merged
Merged
Conversation
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
2 tasks
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
Contributor
|
I was able to select "No Schema" in addition to two schemas. I think it's not evident what this does to the end user. Maybe it's worth deselecting the other schemas when you select "No Schema" |
Contributor
|
Looks pretty good from my testing, outside of #1253 (comment) which I think will be confusing for users and could be improved. |
…" is selected Signed-off-by: Morgan Chang <shin19991207@gmail.com>
Member
Author
|
@datho7561 Thanks for the review and the suggestion! I updated the behavior now:
|
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
datho7561
approved these changes
May 25, 2026
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Morgan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
yaml-language-server supports validating a YAML file against multiple matching JSON schemas by creating an internal combined schema with JSON Schema
allOf. Because multiple schemas can be valid for one YAML file, the schema picker should allow users to select or deselect multiple schemas instead of forcing a single choice.This PR updates the schema picker behavior:
What issues does this PR fix or reference?
Fixes #1249
Fixes #983
Related to redhat-developer/yaml-language-server#1260
Is it tested? How?
yaml.schemasandyaml/get/jsonSchemaStackOverflow yaml-language-server#1260