A few updates to the instructions to the hello-microshift demo#25
Open
rclements-redhat wants to merge 7 commits into
Open
A few updates to the instructions to the hello-microshift demo#25rclements-redhat wants to merge 7 commits into
rclements-redhat wants to merge 7 commits into
Conversation
Remove space between `-i .bak` in the sed command. The space does not work on RHEL 9.1's sed-4.8-9.el9.x86_64 package.
Update `/etc/host`s instruction with a few more details, and use `oc` command to direct the route's FQDN from `routes/hello-microsoft` into a `route` BASH variable.
Fixed the mkdir -p ~/.kube command. Originally it was making config a directory and the ssh command would fail. Added firewall-cmd rules to ensure ports are open on the MicroShift VM.
Author
|
Had to change the wording from VM to "machine" in a few spots and correct spelling errors. Just squash the commits when merging if the final version is acceptable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through the
hello-microshift-demoand discovered a few areas that could be enhanced. To begin with, thesedcommand should not include a space between-iand.bak. Additionally, I introduced anoccommand, including thejsonpathparameter, to pull the route fromroute/hello-microshiftinto the BASHroutevariable instead of hardcoding 'hello-microshift.local' directly in the instructions.