Fix: DataTable JavaScript serialization vulnerability in caption#502
Open
turfin-logic wants to merge 1 commit into
Open
Fix: DataTable JavaScript serialization vulnerability in caption#502turfin-logic wants to merge 1 commit into
turfin-logic wants to merge 1 commit into
Conversation
Owner
|
Hey @turfin-logic, thanks for this PR. Using Please give an example which of the issues in #500 it solves. |
Author
|
Hey @redimp! This specific PR fixes the Table caption parsing vulnerability mentioned in #500. Specifically, if a user created a table with a malicious caption containing unescaped quotes or JavaScript payloads, the previous string formatting logic in otterwiki/formatter.py would inject it directly into the DataTables initialization script, allowing XSS. Using json.dumps() ensures the caption is safely serialized as a valid JavaScript string literal regardless of its contents. Let me know if you need a specific payload example! |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced manual string quoting with \json.dumps\ to prevent Javascript syntax errors when the caption contains quotes, backslashes, or newlines. Fixes #500.