Skip to content

Add selectable Redis Agent Memory backends#16

Draft
nkanu17 wants to merge 10 commits into
mainfrom
feat/selectable-agent-memory-backends
Draft

Add selectable Redis Agent Memory backends#16
nkanu17 wants to merge 10 commits into
mainfrom
feat/selectable-agent-memory-backends

Conversation

@nkanu17
Copy link
Copy Markdown
Collaborator

@nkanu17 nkanu17 commented May 29, 2026

Summary

  • Add selectable memory backend support for redis-agent-memory and opensource-agent-memory.
  • Keep the self-hosted Agent Memory Server path through agent-memory-client.
  • Update docs and examples to expose REDIS_MEMORY_BACKEND.

Tests

  • make check

nkanu17 added 10 commits May 20, 2026 15:22
Adds a GitHub Actions workflow that builds the `mkdocs.yml`
configuration with the Material theme + mkdocstrings + llmstxt
plugins, then deploys to GitHub Pages via
`actions/deploy-pages@v4` (OIDC, no token needed).

Changes:
- `.github/workflows/docs.yml`: build + deploy on push to main when
  any docs source changes (docs/**, mkdocs.yml, src/**,
  pyproject.toml, uv.lock, the workflow itself). Also supports
  `workflow_dispatch` for manual triggers.
- `mkdocs.yml`: switch `site_url` from the unresolved
  `https://ai.redis.io/adk/` to the GitHub Pages canonical URL
  `https://redis-developer.github.io/adk-redis/`.
- `pyproject.toml`: new `[docs]` optional extra so contributors can
  reproduce the build with `uv sync --extra docs --extra all`.

The workflow uses `mkdocs build` (not `--strict`) on purpose. There
are 44 pre-existing griffe docstring/signature warnings in
`tools/memory/*` (the Memory* tools' docstrings document parameters
that don't appear in the actual function signatures). Those warnings
are real and worth fixing, but should not block doc deploys.
Tracked separately.

Post-merge follow-ups:
- Enable GitHub Pages on the repo (`Settings > Pages > Source: GitHub
  Actions`) so the deploy step has an environment to push to. Can be
  set via API: `gh api -X POST repos/.../pages -f build_type=workflow`.
- Remove mkdocs-macros-plugin from docs extra (not used in mkdocs.yml)
- Remove uv.lock from workflow paths filter (no lockfile committed)
- Add branch guard (if: github.ref == 'refs/heads/main') to deploy job
  so workflow_dispatch from non-main branches cannot overwrite the site
- Header badge now links to redis-developer.github.io/adk-redis/
- Body links updated from relative doc paths to docs site URLs
- Old redis.io docs link preserved in Helpful links section
The mkdocs site is now the primary documentation. The redis.io
integration page is preserved as a secondary reference.
Now that the mkdocs docs site is live, the README serves as a
storefront: what it does, install, one quick start snippet, examples
list, and links to the docs site for everything else.

Removed from README (now in docs site only):
- Search, MCP, and semantic cache quick start snippets
- Search tools breakdown (in-process vs MCP tables)
- Memory backends section
- Semantic cache providers section
- Requirements section
- Full development targets list
- Detailed prerequisites and Docker commands
The site/ directory was being tracked, causing GitHub to report
88.7% HTML. Now gitignored.
Copilot AI review requested due to automatic review settings May 29, 2026 21:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants