Skip to content

test: close PSC and Transit Gateway coverage gaps - #159

Merged
joshrotenberg merged 2 commits into
mainfrom
codex/test-connectivity-coverage
Aug 11, 2026
Merged

test: close PSC and Transit Gateway coverage gaps#159
joshrotenberg merged 2 commits into
mainfrom
codex/test-connectivity-coverage

Conversation

@joshrotenberg

@joshrotenberg joshrotenberg commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Claim issue #146 and bring Private Service Connect and Transit Gateway request/response coverage in line with the neighboring connectivity modules.

Closes #146.

Changes

  • Add dedicated wiremock suites for PSC standalone and Active-Active routes.
  • Cover PSC create/get/update/delete plus endpoint listing, creation scripts, deletion scripts, and endpoint deletion.
  • Add dedicated wiremock suites for Transit Gateway standalone and Active-Active routes.
  • Cover gateway listing, invitation listing/accept/reject, attachment create/update/delete, and the legacy compatibility alias.
  • Assert authentication headers, exact paths, request wire keys, response deserialization, task responses, and error mappings.

Validation

  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features -- -D warnings
  • Focused PSC/TGW suites: 8 passed
  • cargo test --workspace
  • cargo llvm-cov --all-features --summary-only

Coverage results:

  • connectivity/psc.rs: 29.29% → 100% lines, 35.14% → 100% functions, 35.04% → 100% regions
  • connectivity/transit_gateway.rs: 28.35% → 100% lines, 31.03% → 100% functions, 32.65% → 100% regions
  • Total crate line coverage: 68.31% → 76.37%

The final diff was reviewed and contains two dedicated test files with no production behavior change. The existing unified-handler test continues to cover the legacy list_tgw_attachments alias.

Stack

This draft temporarily targets #158's branch so the issue is visibly claimed while #158 runs CI. It will be rebased and retargeted to main after #158 merges.

@joshrotenberg
joshrotenberg changed the base branch from codex/test-error-contract to main August 11, 2026 21:05
@joshrotenberg
joshrotenberg marked this pull request as ready for review August 11, 2026 21:05
@joshrotenberg
joshrotenberg force-pushed the codex/test-connectivity-coverage branch from 7b154bc to 315ac40 Compare August 11, 2026 21:05
@joshrotenberg
joshrotenberg merged commit c09a5d1 into main Aug 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: connectivity PSC and Transit Gateway modules lag far behind sibling connectivity coverage

1 participant