Improvements#4
Open
alabotski wants to merge 9 commits into
Open
Conversation
|
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
AlexOreshkevich
requested changes
Feb 17, 2020
AlexOreshkevich
left a comment
AlexOreshkevich
left a comment
Member
There was a problem hiding this comment.
codeCoverageReport was not added to gradle.build
Member
|
Contributor
Author
|
@AlexOreshkevich codeCoverageReport - already exists |
Contributor
Author
Can you give me more info? |
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=========================================
Coverage 15.94% 15.94%
Complexity 22 22
=========================================
Files 29 29
Lines 207 207
=========================================
Hits 33 33
Misses 174 174 |
# Conflicts: # README.md
AlexOreshkevich
requested review from
AlexOreshkevich
and removed request for
ashalak
March 3, 2020 12:26
Member
|
Issues
======
+ Solved 21
- Added 26
Complexity increasing per file
==============================
- core/src/test/java/com/rednavis/core/CoreModuleTest.java 1
- organization-client/src/test/java/com/rednavis/organization/OrganizationApplicationTest.java 1
- department-client/src/test/java/com/rednavis/department/DepartmentApplicationTest.java 1
- employee-client/src/test/java/com/rednavis/employee/MongoDbContainer.java 1
- discovery-service/src/test/java/com/rednavis/discovery/DiscoveryApplicationTest.java 1
- zuul-service/src/test/java/com/rednavis/zuul/ZuulApplicationTest.java 1
See the complete overview on Codacy |
| * http://localhost:8090/department/info | ||
| * http://localhost:8090/organization/info | ||
| ### Swagger | ||
| - http://localhost:8090/swagger-ui.html |
Member
There was a problem hiding this comment.
| ``` | ||
| $ heroku addons:create mongolab:sandbox | ||
| ``` | ||
| - Deploy code |
Member
There was a problem hiding this comment.
| * http://localhost:8090/department/info | ||
| * http://localhost:8090/organization/info | ||
| ### Swagger | ||
| - http://localhost:8090/swagger-ui.html |
Member
There was a problem hiding this comment.
| ### Test microservice status | ||
| - http://localhost:8090/employeeEntity/info | ||
| - http://localhost:8090/department/info | ||
| - http://localhost:8090/organization/info |
Member
There was a problem hiding this comment.
| * http://localhost:8090/swagger-ui.html | ||
| ## REST API exposed | ||
| ### Eureka | ||
| - http://localhost:8761/ |
Member
There was a problem hiding this comment.
| * http://localhost:8090/department/graphiql | ||
|
|
||
| Test query: | ||
| - http://localhost:8090/department/graphiql |
Member
There was a problem hiding this comment.
| * http://localhost:8090/department/graphiql | ||
|
|
||
| Test query: | ||
| - http://localhost:8090/department/graphiql |
Member
There was a problem hiding this comment.
| ``` | ||
| $ heroku apps:create | ||
| ``` | ||
| - Add a MongoDB database to your Heroku application with MongoLab. Note that your Heroku account must have a credit card attached in order to use free add-ons other than the PostgreSQL and MySQL add-ons. |
Member
There was a problem hiding this comment.
| ``` | ||
| $ heroku login | ||
| ``` | ||
| - Create a new application on Heroku |
Member
There was a problem hiding this comment.
| ``` | ||
| $ git push heroku master | ||
| ``` | ||
| - Look at your application logs to see what is happening behind the scenes. |
Member
There was a problem hiding this comment.
| * http://localhost:8090/mock | ||
| ### Test microservice status | ||
| - http://localhost:8090/employeeEntity/info | ||
| - http://localhost:8090/department/info |
Member
There was a problem hiding this comment.
| ## GraphiQL | ||
| * http://localhost:8090/employee/graphiql | ||
| ### Generate mock data | ||
| - http://localhost:8090/mock |
Member
There was a problem hiding this comment.
| 1. `./gradlew clean bootJar jibDockerBuild` | ||
| 2. `docker-compose up` | ||
| ## Prerequisites | ||
| - OpenJDK 12.0.2 or higher |
Member
There was a problem hiding this comment.
|
|
||
| Test query: | ||
| ### GraphiQL | ||
| - http://localhost:8090/employee/graphiql |
Member
There was a problem hiding this comment.
| * http://localhost:8090/swagger-ui.html | ||
| ## REST API exposed | ||
| ### Eureka | ||
| - http://localhost:8761/ |
Member
There was a problem hiding this comment.
| ## GraphiQL | ||
| * http://localhost:8090/employee/graphiql | ||
| ### Generate mock data | ||
| - http://localhost:8090/mock |
Member
There was a problem hiding this comment.
| * http://localhost:8090/organization/graphiql | ||
|
|
||
| Test query: | ||
| - http://localhost:8090/organization/graphiql |
Member
There was a problem hiding this comment.
| ``` | ||
| $ heroku logs | ||
| ``` | ||
| - If your application deploys without timing out then open it as follows. |
Member
There was a problem hiding this comment.
| ## Generate mock data | ||
| * http://localhost:8090/mock | ||
| ### Test microservice status | ||
| - http://localhost:8090/employeeEntity/info |
Member
There was a problem hiding this comment.
| * http://localhost:8090/organization/graphiql | ||
|
|
||
| Test query: | ||
| - http://localhost:8090/organization/graphiql |
Member
There was a problem hiding this comment.
| * http://localhost:8090/mock | ||
| ### Test microservice status | ||
| - http://localhost:8090/employeeEntity/info | ||
| - http://localhost:8090/department/info |
Member
There was a problem hiding this comment.
| ### Test microservice status | ||
| - http://localhost:8090/employeeEntity/info | ||
| - http://localhost:8090/department/info | ||
| - http://localhost:8090/organization/info |
Member
There was a problem hiding this comment.
| ``` | ||
|
|
||
| ## Heroku setup | ||
| - Login to your heroku account from CLI |
Member
There was a problem hiding this comment.
|
|
||
| Test query: | ||
| ### GraphiQL | ||
| - http://localhost:8090/employee/graphiql |
Member
There was a problem hiding this comment.
| ## Generate mock data | ||
| * http://localhost:8090/mock | ||
| ### Test microservice status | ||
| - http://localhost:8090/employeeEntity/info |
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.